Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao
authorMichael Kohler <mkohler@picobudget.com>
Thu, 03 Aug 2017 21:39:21 +0200
changeset 372875 64526a900fd51d1fb784fca7eac2ae9b0bae30d1
parent 372874 4b913ce6d82781f8680c720061d766cb80cda2e7
child 372876 0ff0ccbd52c1ed0cacf159192775c0a43d095435
push id48008
push userkwierso@gmail.com
push dateFri, 04 Aug 2017 09:40:02 +0000
treeherderautoland@64526a900fd5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1366363
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao MozReview-Commit-ID: 3n1i0CXsvC8
browser/components/nsBrowserGlue.js
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -619,28 +619,28 @@ BrowserGlue.prototype = {
 
     SessionStore.init();
 
     if (AppConstants.INSTALL_COMPACT_THEMES) {
       let vendorShortName = gBrandBundle.GetStringFromName("vendorShortName");
 
       LightweightThemeManager.addBuiltInTheme({
         id: "firefox-compact-light@mozilla.org",
-        name: gBrowserBundle.GetStringFromName("compactLightTheme.name"),
-        description: gBrowserBundle.GetStringFromName("compactLightTheme.description"),
+        name: gBrowserBundle.GetStringFromName("lightTheme.name"),
+        description: gBrowserBundle.GetStringFromName("lightTheme.description"),
         headerURL: "resource:///chrome/browser/content/browser/defaultthemes/compact.header.png",
         iconURL: "resource:///chrome/browser/content/browser/defaultthemes/compactlight.icon.svg",
         textcolor: "black",
         accentcolor: "white",
         author: vendorShortName,
       });
       LightweightThemeManager.addBuiltInTheme({
         id: "firefox-compact-dark@mozilla.org",
-        name: gBrowserBundle.GetStringFromName("compactDarkTheme.name"),
-        description: gBrowserBundle.GetStringFromName("compactDarkTheme.description"),
+        name: gBrowserBundle.GetStringFromName("darkTheme.name"),
+        description: gBrowserBundle.GetStringFromName("darkTheme.description"),
         headerURL: "resource:///chrome/browser/content/browser/defaultthemes/compact.header.png",
         iconURL: "resource:///chrome/browser/content/browser/defaultthemes/compactdark.icon.svg",
         textcolor: "white",
         accentcolor: "black",
         author: vendorShortName,
       });
     }
 
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -212,23 +212,23 @@ addonInstallErrorIncompatible=%3$S could
 
 # LOCALIZATION NOTE (addonInstallErrorBlocklisted): %S is add-on name
 addonInstallErrorBlocklisted=%S could not be installed because it has a high risk of causing stability or security problems.
 
 unsignedAddonsDisabled.message=One or more installed add-ons cannot be verified and have been disabled.
 unsignedAddonsDisabled.learnMore.label=Learn More
 unsignedAddonsDisabled.learnMore.accesskey=L
 
-# LOCALIZATION NOTE (compactLightTheme.name): This is displayed in about:addons -> Appearance
-compactLightTheme.name=Compact Light
-compactLightTheme.description=A compact theme with a light color scheme.
+# LOCALIZATION NOTE (lightTheme.name): This is displayed in about:addons -> Appearance
+lightTheme.name=Light
+lightTheme.description=A theme with a light color scheme.
 
-# LOCALIZATION NOTE (compactDarkTheme.name): This is displayed in about:addons -> Appearance
-compactDarkTheme.name=Compact Dark
-compactDarkTheme.description=A compact theme with a dark color scheme.
+# LOCALIZATION NOTE (darkTheme.name): This is displayed in about:addons -> Appearance
+darkTheme.name=Dark
+darkTheme.description=A theme with a dark color scheme.
 
 # LOCALIZATION NOTE (lwthemeInstallRequest.message2): %S will be replaced with
 # the host name of the site.
 lwthemeInstallRequest.message2=This site (%S) attempted to install a theme.
 lwthemeInstallRequest.allowButton2=Allow
 lwthemeInstallRequest.allowButton.accesskey2=a
 
 # LOCALIZATION NOTE (lwthemeNeedsRestart.message):