Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|. r=sebastian
authorNick Alexander <nalexander@mozilla.com>
Wed, 19 Jul 2017 12:54:10 -0700
changeset 370047 636f4f4833597636f058524674265ff94bff34f2
parent 370046 95efad45c16f1bd202f7246ee421ecac4e03eef5
child 370048 2b78ed90d46333844e91a9debcee3381e4fe7cc4
push id46959
push users.kaspari@gmail.com
push dateFri, 21 Jul 2017 11:49:42 +0000
treeherderautoland@2b78ed90d463 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1382774
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382774 - Pre: Don't fail |mach android gradle-dependencies|. r=sebastian MozReview-Commit-ID: CI2Kqb1kceP
mobile/android/mach_commands.py
--- a/mobile/android/mach_commands.py
+++ b/mobile/android/mach_commands.py
@@ -289,19 +289,22 @@ class MachCommands(MachCommandBase):
             'app:findbugsHtmlOfficialPhotonDebug',
             'app:lintOfficialPhotonDebug',
             # Does not include Gecko binaries -- see mobile/android/gradle/with_gecko_binaries.gradle.
             'geckoview:assembleWithoutGeckoBinaries',
             # So that we pick up the test dependencies for the builders.
             'geckoview_example:assembleWithoutGeckoBinaries',
             'geckoview_example:assembleWithoutGeckoBinariesAndroidTest',
         ]
+        # We don't want to gate producing dependency archives on clean
+        # lint or checkstyle, particularly because toolchain versions
+        # can change the outputs for those processes.
         ret = self.gradle(gradle_targets + ["--continue"] + args, verbose=True)
 
-        return ret
+        return 0
 
 
     @Command('gradle', category='devenv',
         description='Run gradle.',
         conditions=[conditions.is_android])
     @CommandArgument('-v', '--verbose', action='store_true',
         help='Verbose output for what commands the build is running.')
     @CommandArgument('args', nargs=argparse.REMAINDER)