Bug 1708534 - Use the specified input colours for dark and light built-in themes. r=jaws
authorMike Conley <mconley@mozilla.com>
Wed, 12 May 2021 20:45:30 +0000
changeset 579552 633b705d14eb3761c66fdea6d6c6bae63be0db54
parent 579551 e7d5f2590362b01d15df7cbe09622121201f677f
child 579553 e7e6e3b008ec0a3f446c480affbbc7d9faffd602
push id143062
push usermconley@mozilla.com
push dateThu, 13 May 2021 00:20:06 +0000
treeherderautoland@633b705d14eb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1708534
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1708534 - Use the specified input colours for dark and light built-in themes. r=jaws It looks like we erroneously used the placeholder colour for the dark theme input colour. This updates the dark theme to use the correct colour. It also updates the light theme to use the same input colours as defined in the light variation of the system theme. Differential Revision: https://phabricator.services.mozilla.com/D115000
browser/themes/addons/dark/manifest.json
browser/themes/addons/light/manifest.json
toolkit/mozapps/extensions/default-theme/manifest.json
--- a/browser/themes/addons/dark/manifest.json
+++ b/browser/themes/addons/dark/manifest.json
@@ -43,17 +43,17 @@
       "button_hover": "rgb(82,82,94)",
       "button_active": "rgb(91,91,102)",
       "button_primary": "rgb(0, 221, 255)",
       "button_primary_hover": "rgb(128, 235, 255)",
       "button_primary_active": "rgb(170, 242, 255)",
       "button_primary_color": "rgb(43, 42, 51)",
       "error_text_color": "rgb(255, 154, 162)",
       "input_background": "#42414D",
-      "input_color": "#BFBFC9",
+      "input_color": "rgb(251,251,254)",
       "input_border": "#8f8f9d",
       "input_border_error": "rgb(255, 132, 138)",
       "zoom_controls": "rgb(74,74,85)",
       "autocomplete_popup_separator": "rgb(82,82,94)",
       "appmenu_update_icon_color": "#54FFBD",
       "appmenu_warning_icon_color": "#FFBD4F",
       "appmenu_info_icon_color": "#80EBFF",
       "tab_icon_overlay_stroke": "rgb(66,65,77)",
--- a/browser/themes/addons/light/manifest.json
+++ b/browser/themes/addons/light/manifest.json
@@ -41,52 +41,61 @@
       "button": "rgba(207,207,216,.33)",
       "button_hover": "rgba(207,207,216,.66)",
       "button_active": "rgb(207,207,216)",
       "button_primary": "rgb(0, 97, 224)",
       "button_primary_hover": "rgb(2, 80, 187)",
       "button_primary_active": "rgb(5, 62, 148)",
       "button_primary_color": "rgb(251, 251, 254)",
       "error_text_color": "rgb(197,0,66)",
+      "input_color": "rgb(21,20,26)",
+      "input_background": "rgb(255,255,255)",
+      "input_border_error": "#E22850",
       "autocomplete_popup_hover": "rgb(240,240,244)",
       "autocomplete_popup_separator": "rgb(240,240,244)",
       "appmenu_update_icon_color": "#2AC3A2",
       "appmenu_warning_icon_color": "#FFA436",
       "appmenu_info_icon_color": "#0090ED",
       "tab_icon_overlay_stroke": "rgb(255,255,255)",
       "tab_icon_overlay_fill": "rgb(91,91,102)"
     },
     "properties": {
       "panel_hover": "color-mix(in srgb, currentColor 12%, transparent)",
       "panel_active": "color-mix(in srgb, currentColor 20%, transparent)",
       "panel_active_darker": "color-mix(in srgb, currentColor 27%, transparent)",
-      "toolbar_field_icon_opacity": "0.72"
+      "toolbar_field_icon_opacity": "0.72",
+      "input_border_color": "color-mix(in srgb, currentColor 41%, transparent)"
     }
   },
 
   "theme_experiment": {
     "stylesheet": "experiment.css",
     "colors": {
       "popup_action_color": "--urlbar-popup-action-color",
       "button": "--button-bgcolor",
       "button_hover": "--button-hover-bgcolor",
       "button_active": "--button-active-bgcolor",
       "button_primary": "--button-primary-bgcolor",
       "button_primary_hover": "--button-primary-hover-bgcolor",
       "button_primary_active": "--button-primary-active-bgcolor",
       "button_primary_color": "--button-primary-color",
       "error_text_color": "--error-text-color",
+      "input_background": "--input-bgcolor",
+      "input_color": "--input-color",
+      "input_border": "--input-border-color",
+      "input_border_error": "--input-error-border-color",
       "autocomplete_popup_hover": "--autocomplete-popup-hover-background",
       "autocomplete_popup_separator": "--autocomplete-popup-separator-color",
       "appmenu_update_icon_color": "--panel-banner-item-update-supported-bgcolor",
       "appmenu_warning_icon_color": "--panel-banner-item-warning-icon-bgcolor",
       "appmenu_info_icon_color": "--panel-banner-item-info-icon-bgcolor",
       "tab_icon_overlay_stroke": "--tab-icon-overlay-stroke",
       "tab_icon_overlay_fill": "--tab-icon-overlay-fill"
     },
     "properties": {
       "panel_hover": "--arrowpanel-dimmed",
       "panel_active": "-arrowpanel-dimmed-further",
       "panel_active_darker": "--arrowpanel-dimmed-even-further",
-      "toolbar_field_icon_opacity": "--urlbar-icon-fill-opacity"
+      "toolbar_field_icon_opacity": "--urlbar-icon-fill-opacity",
+      "input_border_color": "--input-border-color"
     }
   }
 }
--- a/toolkit/mozapps/extensions/default-theme/manifest.json
+++ b/toolkit/mozapps/extensions/default-theme/manifest.json
@@ -46,17 +46,17 @@
       "button_hover": "rgb(82,82,94)",
       "button_active": "rgb(91,91,102)",
       "button_primary": "rgb(0, 221, 255)",
       "button_primary_hover": "rgb(128, 235, 255)",
       "button_primary_active": "rgb(170, 242, 255)",
       "button_primary_color": "rgb(43, 42, 51)",
       "error_text_color": "rgb(255, 154, 162)",
       "input_background": "#42414D",
-      "input_color": "#BFBFC9",
+      "input_color": "rgb(251,251,254)",
       "input_border": "#8f8f9d",
       "input_border_error": "rgb(255, 132, 138)",
       "zoom_controls": "rgb(74,74,85)",
       "autocomplete_popup_separator": "rgb(82,82,94)",
       "appmenu_update_icon_color": "#54FFBD",
       "appmenu_warning_icon_color": "#FFBD4F",
       "appmenu_info_icon_color": "#80EBFF",
       "tab_icon_overlay_stroke": "rgb(66,65,77)",