Bug 1518965: Remove nsPresContext::mLastResizeEventVisibleArea and accessor functions that are never used. r=botond
authorBrad Werth <bwerth@mozilla.com>
Thu, 10 Jan 2019 01:56:41 +0000
changeset 453191 606870290cd6ece614fe54d67f273fe2a803ecdd
parent 453190 6692901d43cf3417a1426444b43cd3e7263a5740
child 453192 5665c5f251985c3f2e54a5bb0f18db99a58b8acd
push id75753
push userbwerth@mozilla.com
push dateThu, 10 Jan 2019 01:57:38 +0000
treeherderautoland@606870290cd6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbotond
bugs1518965
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518965: Remove nsPresContext::mLastResizeEventVisibleArea and accessor functions that are never used. r=botond Differential Revision: https://phabricator.services.mozilla.com/D16126
layout/base/nsPresContext.cpp
layout/base/nsPresContext.h
--- a/layout/base/nsPresContext.cpp
+++ b/layout/base/nsPresContext.cpp
@@ -171,21 +171,16 @@ nsPresContext::nsPresContext(dom::Docume
       mTextZoom(1.0),
       mEffectiveTextZoom(1.0),
       mFullZoom(1.0),
       mOverrideDPPX(0.0),
       mLastFontInflationScreenSize(gfxSize(-1.0, -1.0)),
       mCurAppUnitsPerDevPixel(0),
       mAutoQualityMinFontSizePixelsPref(0),
       mLangService(nsLanguageAtomService::GetService()),
-      // origin nscoord_MIN is impossible, so the first ResizeReflow always
-      // fires
-      mLastResizeEventVisibleArea(nsRect(nscoord_MIN, nscoord_MIN,
-                                         NS_UNCONSTRAINEDSIZE,
-                                         NS_UNCONSTRAINEDSIZE)),
       mPageSize(-1, -1),
       mPageScale(0.0),
       mPPScale(1.0f),
       mDefaultColor(NS_RGBA(0, 0, 0, 0)),
       mBackgroundColor(NS_RGB(0xFF, 0xFF, 0xFF)),
       mLinkColor(NS_RGB(0x00, 0x00, 0xEE)),
       mActiveLinkColor(NS_RGB(0xEE, 0x00, 0x00)),
       mVisitedLinkColor(NS_RGB(0x55, 0x1A, 0x8B)),
--- a/layout/base/nsPresContext.h
+++ b/layout/base/nsPresContext.h
@@ -471,22 +471,16 @@ class nsPresContext : public nsISupports
       // Visible area does not affect media queries when paginated.
       if (!IsPaginated()) {
         MediaFeatureValuesChanged(
             {mozilla::MediaFeatureChangeReason::ViewportChange});
       }
     }
   }
 
-  bool ShouldFireResizeEvent() const {
-    return !mLastResizeEventVisibleArea.IsEqualEdges(mVisibleArea);
-  }
-
-  void WillFireResizeEvent() { mLastResizeEventVisibleArea = mVisibleArea; }
-
   /**
    * Return true if this presentation context is a paginated
    * context.
    */
   bool IsPaginated() const { return mPaginated; }
 
   /**
    * Sets whether the presentation context can scroll for a paginated
@@ -1307,17 +1301,16 @@ class nsPresContext : public nsISupports
   AutoTArray<TransactionInvalidations, 4> mTransactions;
 
   // text performance metrics
   mozilla::UniquePtr<gfxTextPerfMetrics> mTextPerf;
 
   mozilla::UniquePtr<gfxMissingFontRecorder> mMissingFonts;
 
   nsRect mVisibleArea;
-  nsRect mLastResizeEventVisibleArea;
   nsSize mPageSize;
   float mPageScale;
   float mPPScale;
 
   nscolor mDefaultColor;
   nscolor mBackgroundColor;
 
   nscolor mLinkColor;