Bug 1377006 - Part 2: Add disableHighlight option in formautofill doorhanger. r=lchang,MattN
authorsteveck-chung <schung@mozilla.com>
Thu, 27 Jul 2017 18:11:12 +0800
changeset 379704 5ead094a4792
parent 379703 735a60b17ee4
child 379705 2e507cfef60d
push id50747
push userlchang@mozilla.com
push dateFri, 08 Sep 2017 09:22:11 +0000
treeherderautoland@5ead094a4792 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslchang, MattN
bugs1377006
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1377006 - Part 2: Add disableHighlight option in formautofill doorhanger. r=lchang,MattN MozReview-Commit-ID: 3UkSIUeM0oK
browser/extensions/formautofill/FormAutofillDoorhanger.jsm
--- a/browser/extensions/formautofill/FormAutofillDoorhanger.jsm
+++ b/browser/extensions/formautofill/FormAutofillDoorhanger.jsm
@@ -42,16 +42,17 @@ const CONTENT = {
       id: "autofill-address-notification-icon",
       URL: "chrome://formautofill/content/formfill-anchor.svg",
       tooltiptext: GetStringFromName("openAutofillMessagePanel"),
     },
     mainAction: {
       label: GetStringFromName(changeAutofillOptsKey),
       accessKey: "C",
       callbackState: "open-pref",
+      disableHighlight: true,
     },
     options: {
       persistWhileVisible: true,
       popupIconURL: "chrome://formautofill/content/icon-address-save.svg",
       checkbox: {
         get checked() {
           return Services.prefs.getBoolPref("services.sync.engine.addresses");
         },
@@ -136,19 +137,19 @@ let FormAutofillDoorhanger = {
    * @returns {Array<Object>}
               Return the mainAction and secondary actions in an array for showing doorhanger
    */
   _createActions(mainActionParams, secondaryActionParams, resolve) {
     if (!mainActionParams) {
       return [null, null];
     }
 
-    let {label, accessKey, callbackState} = mainActionParams;
+    let {label, accessKey, disableHighlight, callbackState} = mainActionParams;
     let callback = resolve.bind(null, callbackState);
-    let mainAction = {label, accessKey, callback};
+    let mainAction = {label, accessKey, callback, disableHighlight};
 
     if (!secondaryActionParams) {
       return [mainAction, null];
     }
 
     let secondaryActions = [];
     for (let params of secondaryActionParams) {
       let cb = resolve.bind(null, params.callbackState);