Bug 1659771 - Remove obsolete nsIProfiler.AddMarker API, r=gerald.
authorFlorian Quèze <florian@queze.net>
Tue, 18 Aug 2020 22:52:55 +0000
changeset 545301 5dfd6570eddba5aaa1da1cb6e2ad31839c07834c
parent 545300 b3aed0b0c1b47e0a80318c5f367b4bb7f6808ef3
child 545302 aed8ee7d70f420c7ff93109dcf9f3f3733bcfff6
push id124497
push userfqueze@mozilla.com
push dateWed, 19 Aug 2020 09:56:13 +0000
treeherderautoland@5dfd6570eddb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1659771
milestone81.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1659771 - Remove obsolete nsIProfiler.AddMarker API, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D87470
tools/profiler/gecko/nsIProfiler.idl
tools/profiler/gecko/nsProfiler.cpp
--- a/tools/profiler/gecko/nsIProfiler.idl
+++ b/tools/profiler/gecko/nsIProfiler.idl
@@ -42,17 +42,16 @@ interface nsIProfiler : nsISupports
                      [optional] in double aDuration);
   void StopProfiler();
   boolean IsPaused();
   void Pause();
   void Resume();
   boolean IsSamplingPaused();
   void PauseSampling();
   void ResumeSampling();
-  void AddMarker(in string aMarker);
 
   /*
    * Resolves the returned promise after at least one full periodic sampling.
    * Rejects the promise if sampler is not running (yet, or anymore, or paused).
    * This is mainly useful in tests, to wait just long enough to guarantee that
    * one sample was taken in the main process.
    */
   [implicit_jscontext]
--- a/tools/profiler/gecko/nsProfiler.cpp
+++ b/tools/profiler/gecko/nsProfiler.cpp
@@ -183,22 +183,16 @@ nsProfiler::PauseSampling() {
 
 NS_IMETHODIMP
 nsProfiler::ResumeSampling() {
   profiler_resume_sampling();
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsProfiler::AddMarker(const char* aMarker) {
-  PROFILER_ADD_MARKER(aMarker, OTHER);
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsProfiler::ClearAllPages() {
   profiler_clear_all_pages();
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsProfiler::WaitOnePeriodicSampling(JSContext* aCx, Promise** aPromise) {
   MOZ_ASSERT(NS_IsMainThread());