Bug 1777627 Part 3 - Improve BlockReflowState::mBorderPadding's documentation. r=emilio
authorTing-Yu Lin <tlin@mozilla.com>
Tue, 05 Jul 2022 23:43:52 +0000
changeset 623105 5da16396fa22b03b190b7d87f597ab11fa810b1d
parent 623104 fa58e578d6b3ea469abf083f0fe036dd0e42d864
child 623106 cfcf61dedb350b96952a742d0466de479c17aa4e
push id165710
push usertlin@mozilla.com
push dateTue, 05 Jul 2022 23:46:27 +0000
treeherderautoland@5da16396fa22 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1777627
milestone104.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1777627 Part 3 - Improve BlockReflowState::mBorderPadding's documentation. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D150833
layout/generic/BlockReflowState.h
--- a/layout/generic/BlockReflowState.h
+++ b/layout/generic/BlockReflowState.h
@@ -195,19 +195,16 @@ class BlockReflowState {
       nsIFrame* aFloatAvoidingBlock,
       const nsFlowAreaRect& aFloatAvailableSpace) const;
 
   // True if the current block-direction coordinate, for placing the children
   // within the content area, is still adjacent with the block-start of the
   // content area.
   bool IsAdjacentWithBStart() const { return mBCoord == ContentBStart(); }
 
-  /**
-   * Return mBlock's computed physical border+padding with GetSkipSides applied.
-   */
   const LogicalMargin& BorderPadding() const { return mBorderPadding; }
 
   // Reconstruct the previous block-end margin that goes before |aLine|.
   void ReconstructMarginBefore(nsLineList::iterator aLine);
 
   // Caller must have called GetFloatAvailableSpace for the correct position
   // (which need not be the current mBCoord).
   void ComputeFloatAvoidingOffsets(nsIFrame* aFloatAvoidingBlock,
@@ -333,17 +330,18 @@ class BlockReflowState {
   // which we know is adjacent to the top of the block (in other words,
   // all lines before it are empty and do not have clearance. This line is
   // always before the current line.
   nsLineList::iterator mLineAdjacentToTop;
 
   // The current block-direction coordinate in the block
   nscoord mBCoord;
 
-  // mBlock's computed physical border+padding with GetSkipSides applied.
+  // mBlock's computed logical border+padding with pre-reflow skip sides applied
+  // (See the constructor and nsIFrame::PreReflowBlockLevelLogicalSkipSides).
   LogicalMargin mBorderPadding;
 
   // The overflow areas of all floats placed so far
   OverflowAreas mFloatOverflowAreas;
 
   nsFloatCacheFreeList mFloatCacheFreeList;
 
   // Previous child. This is used when pulling up a frame to update