Backed out changeset 3c51f1d45483 (bug 1319445) for timing out while checking for video stats in mda tests. r=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Mon, 09 Jan 2017 18:29:02 +0100
changeset 328567 5bdd39969d244c0639f746350091f9bfeaba1ed7
parent 328566 83fbff91e9d2aec7ebc92c3c2017af39ebc49a36
child 328568 e5c3a2c6ba777b677f7e29b683fe1d6ea753e2d9
push id35819
push userarchaeopteryx@coole-files.de
push dateMon, 09 Jan 2017 17:29:24 +0000
treeherderautoland@5bdd39969d24 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1319445
milestone53.0a1
backs out3c51f1d45483bdb0e962ca7b6201a590e70c42f9
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 3c51f1d45483 (bug 1319445) for timing out while checking for video stats in mda tests. r=backout
media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
--- a/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
+++ b/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
@@ -43,17 +43,16 @@
 #include "transportlayer.h"
 #include "transportlayerdtls.h"
 #include "transportlayerice.h"
 #include "runnable_utils.h"
 #include "libyuv/convert.h"
 #include "mozilla/SharedThreadPool.h"
 #if !defined(MOZILLA_EXTERNAL_LINKAGE)
 #include "mozilla/PeerIdentity.h"
-#include "mozilla/Preferences.h"
 #include "mozilla/TaskQueue.h"
 #endif
 #include "mozilla/gfx/Point.h"
 #include "mozilla/gfx/Types.h"
 #include "mozilla/UniquePtr.h"
 #include "mozilla/UniquePtrExtensions.h"
 #include "mozilla/Sprintf.h"
 
@@ -1450,32 +1449,21 @@ void MediaPipelineTransmit::AttachToTrac
   description_ += track_id;
   description_ += "]";
 
   // TODO(ekr@rtfm.com): Check for errors
   MOZ_MTLOG(ML_DEBUG, "Attaching pipeline to track "
             << static_cast<void *>(domtrack_) << " conduit type=" <<
             (conduit_->type() == MediaSessionConduit::AUDIO ?"audio":"video"));
 
-#if !defined(MOZILLA_EXTERNAL_LINKAGE)
-  // With full duplex we don't risk having audio come in late to the MSG
-  // so we won't need a direct listener.
-  const bool enableDirectListener =
-    !Preferences::GetBool("media.navigator.audio.full_duplex", false);
-#else
-  const bool enableDirectListener = true;
-#endif
-
-  if (enableDirectListener) {
-    // Register the Listener directly with the source if we can.
-    // We also register it as a non-direct listener so we fall back to that
-    // if installing the direct listener fails. As a direct listener we get access
-    // to direct unqueued (and not resampled) data.
-    domtrack_->AddDirectListener(listener_);
-  }
+  // Register the Listener directly with the source if we can.
+  // We also register it as a non-direct listener so we fall back to that
+  // if installing the direct listener fails. As a direct listener we get access
+  // to direct unqueued (and not resampled) data.
+  domtrack_->AddDirectListener(listener_);
   domtrack_->AddListener(listener_);
 
 #ifndef MOZILLA_INTERNAL_API
   // this enables the unit tests that can't fiddle with principals and the like
   listener_->SetEnabled(true);
 #endif
 }