Bug 1394641: Update suggestedsites bgcolor for new icons. r=sebastian
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 06 Sep 2017 15:46:22 -0700
changeset 379523 57f74d890cfeda58712bd6b5d2a0e66116714c98
parent 379522 07a89d9a16a7582cc337d7e65fb88dfefb3522a1
child 379524 aa9f9146b198aaacafff5f037b5410f2f7a754cd
push id50684
push usermichael.l.comella@gmail.com
push dateThu, 07 Sep 2017 18:11:07 +0000
treeherderautoland@57f74d890cfe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1394641, 1388379
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1394641: Update suggestedsites bgcolor for new icons. r=sebastian These `bgcolor`s are the background colors of the new icons added in bug 1388379. I was originally intending to remove the bgcolor attribute in this bug, which is why I didn't change the colors in the previous bug. I decided not to remove the bgcolor attribute to avoid churn: we'd have to maintain multiple permitted schemas for the region.properties (one where bgcolor is required and one where it is not), update the documentation to clarify the changes before and after Firefox 57, communicate the new format to several partners, etc. It seemed easier to continue to require bgcolor and, if there is transparency in the icon, we use bgcolor, otherwise we don't. This is already the way distributions work: some icons have transparency, some don't! In practice, the updated bgcolors on the suggested sites doesn't make a difference: there is no transparency in the new icons so these bgcolors are never shown. MozReview-Commit-ID: GovUjM7VKyG
mobile/locales/en-US/chrome/region.properties
--- a/mobile/locales/en-US/chrome/region.properties
+++ b/mobile/locales/en-US/chrome/region.properties
@@ -54,43 +54,43 @@ browser.contentHandlers.types.0.uri=http
 browser.suggestedsites.list.0=facebook
 browser.suggestedsites.list.1=youtube
 browser.suggestedsites.list.2=amazon
 browser.suggestedsites.list.3=wikipedia
 browser.suggestedsites.list.4=twitter
 
 browser.suggestedsites.facebook.title=Facebook
 browser.suggestedsites.facebook.url=https://m.facebook.com/
-browser.suggestedsites.facebook.bgcolor=#385185
+browser.suggestedsites.facebook.bgcolor=#3B5998
 
 browser.suggestedsites.youtube.title=YouTube
 browser.suggestedsites.youtube.url=https://m.youtube.com/
-browser.suggestedsites.youtube.bgcolor=#cd201f
+browser.suggestedsites.youtube.bgcolor=#DB2532
 
 browser.suggestedsites.amazon.title=Amazon
 browser.suggestedsites.amazon.url=https://www.amazon.com/
-browser.suggestedsites.amazon.bgcolor=#000000
+browser.suggestedsites.amazon.bgcolor=#FFFFFF
 
 browser.suggestedsites.wikipedia.title=Wikipedia
 browser.suggestedsites.wikipedia.url=https://www.wikipedia.org/
 browser.suggestedsites.wikipedia.bgcolor=#000000
 
 browser.suggestedsites.twitter.title=Twitter
 browser.suggestedsites.twitter.url=https://mobile.twitter.com/
-browser.suggestedsites.twitter.bgcolor=#55acee
+browser.suggestedsites.twitter.bgcolor=#1DA1F2
 
 browser.suggestedsites.restricted.list.0=restricted_fxsupport
 browser.suggestedsites.restricted.list.1=webmaker
 browser.suggestedsites.restricted.list.2=restricted_mozilla
 
 browser.suggestedsites.restricted_fxsupport.title=Firefox Help and Support for restricted profiles on Android tablets
 browser.suggestedsites.restricted_fxsupport.url=https://support.mozilla.org/kb/controlledaccess
-browser.suggestedsites.restricted_fxsupport.bgcolor=#f37c00
+browser.suggestedsites.restricted_fxsupport.bgcolor=#FF9400
 
 browser.suggestedsites.webmaker.title=Learn the Web: Mozilla Webmaker
 browser.suggestedsites.webmaker.url=https://webmaker.org/
-browser.suggestedsites.webmaker.bgcolor=#f37c00
+browser.suggestedsites.webmaker.bgcolor=#5B6C86
 
 # LOCALIZATION NOTE: browser.suggestedsites.restricted_mozilla.url must be different from browser.suggestedsites.mozilla.url
 browser.suggestedsites.restricted_mozilla.title=The Mozilla Project
 browser.suggestedsites.restricted_mozilla.url=https://www.mozilla.org
-browser.suggestedsites.restricted_mozilla.bgcolor=#ce4e41
+browser.suggestedsites.restricted_mozilla.bgcolor=#000000
 browser.suggestedsites.restricted_mozilla.trackingid=632