Bug 1662703 - Tweak appearance: button usage in browser/ and toolkit/. r=dao
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 09 Sep 2020 23:13:53 +0000
changeset 548064 56e1f7f0268b209f4c5da46ebbe945f537694979
parent 548063 ecc467fedeebc0328c6077d15c0c6210961c15a4
child 548065 baab244deeb06579c5d498ee5a0bbeb0bac3c19a
push id125967
push userealvarez@mozilla.com
push dateWed, 09 Sep 2020 23:17:15 +0000
treeherderautoland@56e1f7f0268b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1662703
milestone82.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1662703 - Tweak appearance: button usage in browser/ and toolkit/. r=dao The protections.css declaration is not needed, because you're setting backgrounds and borders anyways so native appearance is disabled. The button.css change needs to turn into a -moz-default-appearance + appearance combo, but since it's in three different places, just put it in xul.css instead. Differential Revision: https://phabricator.services.mozilla.com/D89469
browser/components/protections/content/protections.css
toolkit/content/xul.css
toolkit/themes/linux/global/button.css
toolkit/themes/osx/global/button.css
toolkit/themes/windows/global/button.css
--- a/browser/components/protections/content/protections.css
+++ b/browser/components/protections/content/protections.css
@@ -944,17 +944,16 @@ label[for="tab-cryptominer"]:hover ~ #hi
   height: 48px;
 }
 
 #manage-protections,
 #sign-up-for-monitor-link,
 #get-proxy-extension-link,
 .monitor-partial-breaches-link-wrapper,
 .monitor-breaches-link-wrapper {
-  appearance: button;
   background-color: var(--in-content-primary-button-background);
   border: 1px solid transparent;
   border-radius: 2px;
   text-decoration: none;
   color: var(--in-content-selected-text);
 }
 
 #manage-protections:active,
--- a/toolkit/content/xul.css
+++ b/toolkit/content/xul.css
@@ -118,16 +118,23 @@ label html|span.accesskey {
 /********** toolbarbutton **********/
 
 toolbar[mode="icons"] .toolbarbutton-text,
 toolbar[mode="text"] .toolbarbutton-icon,
 html|label.toolbarbutton-badge:empty {
   display: none;
 }
 
+/********** button **********/
+
+button {
+  -moz-default-appearance: button;
+  appearance: auto;
+}
+
 /******** browser, editor, iframe ********/
 
 browser,
 editor,
 iframe {
   display: inline;
 }
 
--- a/toolkit/themes/linux/global/button.css
+++ b/toolkit/themes/linux/global/button.css
@@ -6,17 +6,16 @@
   == Styles used by the XUL button element.
   ======================================================================= */
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* :::::::::: button :::::::::: */
 
 button {
-  appearance: button;
   margin: 1px 5px 2px;
   min-width: 6.3em;
   color: ButtonText;
   text-shadow: none;
 }
 
 .button-box {
   appearance: auto;
--- a/toolkit/themes/osx/global/button.css
+++ b/toolkit/themes/osx/global/button.css
@@ -1,16 +1,15 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 button {
-  appearance: button;
   /* The horizontal margin used here come from the Aqua Human Interface
      Guidelines, there should be 12 pixels between two buttons. */
   margin: 5px 6px 3px;
   min-width: 79px;
   color: ButtonText;
   text-shadow: none;
 }
 
--- a/toolkit/themes/windows/global/button.css
+++ b/toolkit/themes/windows/global/button.css
@@ -6,17 +6,16 @@
   == Styles used by the XUL button element.
   ======================================================================= */
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* :::::::::: button :::::::::: */
 
 button {
-  appearance: button;
   margin: 1px 5px 2px;
   min-width: 6.3em;
   color: ButtonText;
   text-shadow: none;
 }
 
 .button-box {
   padding-block: 2px 3px;