Bug 1501802 - Update tooltool.py fetch_file to log.info exceptions instead of log.debug, r=garbas
☠☠ backed out by 48720735b142 ☠ ☠
authorBob Clary <bclary@bclary.com>
Sat, 10 Nov 2018 03:10:08 -0800
changeset 446473 565215cf2e5e42034860257f4ea4b5d0b0adf75d
parent 446472 aa32ba9e6df3e20aab896a63538c8e8a432b4988
child 446474 b0805a8cf6eb120525408dd486ca2c362afb2db3
push id73020
push usergszorc@mozilla.com
push dateThu, 15 Nov 2018 00:40:00 +0000
treeherderautoland@565215cf2e5e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgarbas
bugs1501802
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1501802 - Update tooltool.py fetch_file to log.info exceptions instead of log.debug, r=garbas
python/mozbuild/mozbuild/action/tooltool.py
testing/mozharness/external_tools/tooltool.py
--- a/python/mozbuild/mozbuild/action/tooltool.py
+++ b/python/mozbuild/mozbuild/action/tooltool.py
@@ -489,20 +489,19 @@ def fetch_file(base_urls, file_record, g
                     out.write(indata)
                     size += len(indata)
                     if indata == '':
                         k = False
                 log.info("File %s fetched from %s as %s" %
                          (file_record.filename, base_url, temp_path))
                 fetched_path = temp_path
                 break
-        except (urllib2.URLError, urllib2.HTTPError, ValueError) as e:
+        except (urllib2.URLError, urllib2.HTTPError, ValueError):
             log.info("...failed to fetch '%s' from %s" %
-                     (file_record.filename, base_url))
-            log.debug("%s" % e)
+                     (file_record.filename, base_url), exc_info=True)
         except IOError:  # pragma: no cover
             log.info("failed to write to temporary file for '%s'" %
                      file_record.filename, exc_info=True)
 
     # cleanup temp file in case of issues
     if fetched_path:
         return os.path.split(fetched_path)[1]
     else:
--- a/testing/mozharness/external_tools/tooltool.py
+++ b/testing/mozharness/external_tools/tooltool.py
@@ -487,20 +487,19 @@ def fetch_file(base_urls, file_record, g
                     out.write(indata)
                     size += len(indata)
                     if indata == '':
                         k = False
                 log.info("File %s fetched from %s as %s" %
                          (file_record.filename, base_url, temp_path))
                 fetched_path = temp_path
                 break
-        except (urllib2.URLError, urllib2.HTTPError, ValueError) as e:
+        except (urllib2.URLError, urllib2.HTTPError, ValueError):
             log.info("...failed to fetch '%s' from %s" %
-                     (file_record.filename, base_url))
-            log.debug("%s" % e)
+                     (file_record.filename, base_url), exc_info=True)
         except IOError:  # pragma: no cover
             log.info("failed to write to temporary file for '%s'" %
                      file_record.filename, exc_info=True)
 
     # cleanup temp file in case of issues
     if fetched_path:
         return os.path.split(fetched_path)[1]
     else: