Backed out changeset e900a3d074b8 (bug 1258797) for failing eslint at toolkit/mozapps/downloads/DownloadLastDir.jsm:150. r=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Sun, 01 Oct 2017 00:36:43 +0200
changeset 383890 562b8f9ed39c21bbb30e75fdff6376ff18b3fd9e
parent 383889 65a1e4064a52ebd60ec55fdf0380405b97f78a8e
child 383897 79ffbb704b281e5fe67711f50fced5c5f15266a2
push id52421
push userarchaeopteryx@coole-files.de
push dateSat, 30 Sep 2017 22:53:21 +0000
treeherderautoland@562b8f9ed39c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1258797
milestone58.0a1
backs oute900a3d074b81b7617e6a65bcd18a02450652990
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e900a3d074b8 (bug 1258797) for failing eslint at toolkit/mozapps/downloads/DownloadLastDir.jsm:150. r=backout
toolkit/mozapps/downloads/DownloadLastDir.jsm
--- a/toolkit/mozapps/downloads/DownloadLastDir.jsm
+++ b/toolkit/mozapps/downloads/DownloadLastDir.jsm
@@ -138,24 +138,19 @@ DownloadLastDir.prototype = {
                          .getService(Components.interfaces.nsIContentPrefService2);
     let result = null;
     cps2.getByDomainAndName(uri, LAST_DIR_PREF, this.fakeContext, {
       handleResult: aResult => result = aResult,
       handleCompletion(aReason) {
         let file = plainPrefFile;
         if (aReason == Components.interfaces.nsIContentPrefCallback2.COMPLETE_OK &&
            result instanceof Components.interfaces.nsIContentPref) {
-          try {
-            file = Components.classes["@mozilla.org/file/local;1"]
-                             .createInstance(Components.interfaces.nsIFile);
-            file.initWithPath(result.value);
-          }
-          catch (e) {
-            file = plainPrefFile;
-          }
+          file = Components.classes["@mozilla.org/file/local;1"]
+                           .createInstance(Components.interfaces.nsIFile);
+          file.initWithPath(result.value);
         }
         aCallback(file);
       }
     });
   },
 
   setFile(aURI, aFile) {
     if (aURI && isContentPrefEnabled()) {