Bug 1603160 - Fix the description of a MediaQueryList test to match what it is testing. r=bzbarsky
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 12 Dec 2019 04:46:54 +0000
changeset 506623 53fbd77c9b9eaedee334d35da55ceb5415ea77c1
parent 506622 1941e31f3d21880bb2c073e0247a041e7cbf00e3
child 506624 d33f90398552d337d7590a491ce48da74852c1b0
push id102961
push userealvarez@mozilla.com
push dateThu, 12 Dec 2019 04:51:04 +0000
treeherderautoland@53fbd77c9b9e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs1603160
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1603160 - Fix the description of a MediaQueryList test to match what it is testing. r=bzbarsky Depends on D56771 Differential Revision: https://phabricator.services.mozilla.com/D56772
testing/web-platform/meta/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html.ini
testing/web-platform/tests/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html
--- a/testing/web-platform/meta/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html.ini
+++ b/testing/web-platform/meta/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html.ini
@@ -1,3 +1,4 @@
 [MediaQueryList-extends-EventTarget-interop.html]
-  [listeners are called in order they were added, ignoring capture parameter]
+  [capturing event listener fires before non-capturing listener at target]
     expected: FAIL
+    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1492446
--- a/testing/web-platform/tests/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html
+++ b/testing/web-platform/tests/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html
@@ -139,16 +139,20 @@ promise_test(async t => {
     triggerMQLEvent(mql);
     await waitForChangesReported();
     assert_equals(calls, 1, "triggerMQLEvent");
 
     mql.dispatchEvent(new Event("change"));
     assert_equals(calls, 2, "dispatchEvent");
 }, "removeListener doesn't remove listener added with addEventListener (capture)");
 
+// See:
+//   * https://github.com/whatwg/dom/issues/746
+//   * https://bugzilla.mozilla.org/show_bug.cgi?id=1492446
+//   * https://bugs.chromium.org/p/chromium/issues/detail?id=949432
 promise_test(async t => {
     const mql = await createMQL(t);
 
     let calls = [];
     mql.addListener(() => {
         calls.push("addListener");
     });
     mql.addEventListener("change", {
@@ -159,10 +163,10 @@ promise_test(async t => {
 
     triggerMQLEvent(mql);
     await waitForChangesReported();
     assert_array_equals(calls, ["addEventListener", "addListener"], "triggerMQLEvent");
 
     calls = [];
     mql.dispatchEvent(new Event("change"));
     assert_array_equals(calls, ["addEventListener", "addListener"], "dispatchEvent");
-}, "listeners are called in order they were added, ignoring capture parameter");
+}, "capturing event listener fires before non-capturing listener at target");
 </script>