Bug 1553473 - Fix PropTypes. r=Honza.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Thu, 23 May 2019 09:26:44 +0000
changeset 475174 53132931ba91cbd4a394734e32abbf387d6c6162
parent 475173 71c4f7fd04f06c928a44738269bbd7615d110bd3
child 475175 c1d2feb784e02c9ed085d1faed370e85edcb3032
push id86180
push usernchevobbe@mozilla.com
push dateThu, 23 May 2019 12:22:08 +0000
treeherderautoland@53132931ba91 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1553473
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1553473 - Fix PropTypes. r=Honza. The FilterBar propType was a leftover from a previous patch where the prop was removed. The SearchBox one was added in a recent patch, but shouldn't have been required (as we have a default in the render function for it). Differential Revision: https://phabricator.services.mozilla.com/D32150
devtools/client/shared/components/SearchBox.js
devtools/client/webconsole/components/FilterBar.js
--- a/devtools/client/shared/components/SearchBox.js
+++ b/devtools/client/shared/components/SearchBox.js
@@ -27,17 +27,17 @@ class SearchBox extends PureComponent {
       keyShortcut: PropTypes.string,
       learnMoreTitle: PropTypes.string,
       learnMoreUrl: PropTypes.string,
       onBlur: PropTypes.func,
       onChange: PropTypes.func.isRequired,
       onFocus: PropTypes.func,
       onKeyDown: PropTypes.func,
       placeholder: PropTypes.string.isRequired,
-      type: PropTypes.string.isRequired,
+      type: PropTypes.string,
     };
   }
 
   constructor(props) {
     super(props);
 
     this.state = {
       value: "",
--- a/devtools/client/webconsole/components/FilterBar.js
+++ b/devtools/client/webconsole/components/FilterBar.js
@@ -23,17 +23,16 @@ const SearchBox = createFactory(require(
 
 loader.lazyRequireGetter(this, "PropTypes", "devtools/client/shared/vendor/react-prop-types");
 
 class FilterBar extends Component {
   static get propTypes() {
     return {
       dispatch: PropTypes.func.isRequired,
       filter: PropTypes.object.isRequired,
-      attachRefToWebConsoleUI: PropTypes.func.isRequired,
       persistLogs: PropTypes.bool.isRequired,
       hidePersistLogsCheckbox: PropTypes.bool.isRequired,
       showContentMessages: PropTypes.bool.isRequired,
       hideShowContentMessagesCheckbox: PropTypes.bool.isRequired,
       filteredMessagesCount: PropTypes.object.isRequired,
       closeButtonVisible: PropTypes.bool,
       closeSplitConsole: PropTypes.func,
     };