Bug 1697623 - Improve proton compact density - round 2. r=harry
authorTim Nguyen <ntim.bugs@gmail.com>
Fri, 12 Mar 2021 03:15:12 +0000
changeset 570799 50a7b1148451dd6b6ef7cec8d79c98e4597e08c1
parent 570798 ad220349088fb3362abb3c5f1f4cf691ddcf885d
child 570800 bfed3f75efcb8aa60dd11b5f1f71c75156159d96
push id138364
push userjwein@mozilla.com
push dateFri, 12 Mar 2021 04:29:25 +0000
treeherderautoland@50a7b1148451 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersharry
bugs1697623
milestone88.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1697623 - Improve proton compact density - round 2. r=harry Differential Revision: https://phabricator.services.mozilla.com/D107924
browser/themes/shared/toolbarbuttons.inc.css
browser/themes/shared/urlbar-searchbar.inc.css
--- a/browser/themes/shared/toolbarbuttons.inc.css
+++ b/browser/themes/shared/toolbarbuttons.inc.css
@@ -38,24 +38,24 @@
 
 @supports -moz-bool-pref("browser.proton.enabled") {
 :root {
   --toolbarbutton-focus-outline: var(--focus-outline);
 }
 } /*** END proton ***/
 @supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root {
-
   --toolbarbutton-outer-padding: 2px;
   --toolbarbutton-inner-padding: 6px;
 }
 } /** END !proton **/
 
 :root[uidensity=compact] {
-  --toolbarbutton-outer-padding: 1px;
+  --toolbarbutton-outer-padding: 3px;
+  --toolbarbutton-inner-padding: 6px;
   --bookmark-block-padding: 1px;
 }
 
 :root[uidensity=touch] {
   --toolbarbutton-inner-padding: 9px;
   --bookmark-block-padding: 7px;
 }
 
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -30,17 +30,17 @@
 #urlbar-container,
 #search-container {
   padding-block: 8px;
   margin-inline: @urlbarMarginInline@;
 }
 
 :root[uidensity=compact] #urlbar-container,
 :root[uidensity=compact] #search-container {
-  padding-block: 5px;
+  padding-block: 4px;
 }
 
 #urlbar,
 #searchbar {
   min-height: var(--urlbar-min-height);
   text-shadow: none;
   color: FieldText;
 }
@@ -618,22 +618,27 @@
   color: inherit;
 }
 
 .urlbar-icon,
 .urlbar-icon-wrapper {
   border-radius: var(--toolbarbutton-border-radius);
 }
 
+:root[uidensity=compact] .urlbar-icon {
+  margin-inline: 1px;
+}
+
 @supports not -moz-bool-pref("browser.proton.urlbar.enabled") {
 .urlbar-icon {
   width: calc(var(--urlbar-min-height) - 2px);
   /* The 0.5px solves a rounding problem where the
     icon hover may not touch the borders */
   height: calc(var(--urlbar-min-height) - 2px + 0.5px);
+  margin-inline: 0;
 }
 
 .urlbar-icon,
 .urlbar-icon-wrapper {
   border-radius: 0;
 }
 } /*** END !proton ***/