Bug 1539256 - Remove enabling AccessibleCaret pref in Android robocop test. r=snorp
authorTing-Yu Lin <tlin@mozilla.com>
Wed, 27 Mar 2019 18:17:03 +0000
changeset 466489 4f609c054ed6b31ecae7c30d1fe0936c4ee337c2
parent 466488 c5325ca87c261fd9a4eeb98aa6a1367f2330e98a
child 466490 aba01506d69136f9cb417724268557f85e94844b
push id81635
push useraethanyc@gmail.com
push dateWed, 27 Mar 2019 22:46:37 +0000
treeherderautoland@4f609c054ed6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1539256, 1493317
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1539256 - Remove enabling AccessibleCaret pref in Android robocop test. r=snorp Bug 1493317 enables AccessibleCaret in unit tests. No need to manually flip the pref. Differential Revision: https://phabricator.services.mozilla.com/D24963
mobile/android/tests/browser/robocop/testAccessibleCarets.js
--- a/mobile/android/tests/browser/robocop/testAccessibleCarets.js
+++ b/mobile/android/tests/browser/robocop/testAccessibleCarets.js
@@ -3,17 +3,16 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
 const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
 const {EventDispatcher} = ChromeUtils.import("resource://gre/modules/Messaging.jsm");
 const {Point} = ChromeUtils.import("resource://gre/modules/Geometry.jsm");
 
-const ACCESSIBLECARET_PREF = "layout.accessiblecaret.enabled";
 const BASE_TEST_URL = "http://mochi.test:8888/tests/robocop/testAccessibleCarets.html";
 const DESIGNMODE_TEST_URL = "http://mochi.test:8888/tests/robocop/testAccessibleCarets2.html";
 
 // Ensures Tabs are completely loaded, viewport and zoom constraints updated, etc.
 const TAB_CHANGE_EVENT = "testAccessibleCarets:TabChange";
 const TAB_STOP_EVENT = "STOP";
 
 const gChromeWin = Services.wm.getMostRecentWindow("navigator:browser");
@@ -148,27 +147,23 @@ function closeSelectionUI() {
  */
 add_task(async function testAccessibleCarets() {
   // Wait to start loading our test page until after the initial browser tab is
   // completely loaded. This allows each tab to complete its layer initialization,
   // importantly, its viewport and zoomContraints info.
   let BrowserApp = gChromeWin.BrowserApp;
   await do_promiseTabChangeEvent(BrowserApp.selectedTab.id, TAB_STOP_EVENT);
 
-  // Ensure Gecko Selection and Touch carets are enabled.
-  Services.prefs.setBoolPref(ACCESSIBLECARET_PREF, true);
-
   // Load test page, wait for load completion, register cleanup.
   let browser = BrowserApp.addTab(BASE_TEST_URL).browser;
   let tab = BrowserApp.getTabForBrowser(browser);
   await do_promiseTabChangeEvent(tab.id, TAB_STOP_EVENT);
 
   do_register_cleanup(function cleanup() {
     BrowserApp.closeTab(tab);
-    Services.prefs.clearUserPref(ACCESSIBLECARET_PREF);
   });
 
   // References to test document elements.
   let doc = browser.contentDocument;
   let ce_LTR_elem = doc.getElementById("LTRcontenteditable");
   let tc_LTR_elem = doc.getElementById("LTRtextContent");
   let i_LTR_elem = doc.getElementById("LTRinput");
   let ta_LTR_elem = doc.getElementById("LTRtextarea");