Bug 710989 - Fix possible memset underflow in Time::Explode(). r=cjones
authorCharles Chan <charles.wh.chan@gmail.com>
Fri, 23 Mar 2012 21:24:07 -0700
changeset 119153 4de05e48b784fc446d008faff58068938375a7f5
parent 119152 d01d7cb7693b7fe1db40858e0f7d90aae3231b33
child 119154 27f62505f15ce4dc3f717bf362a61c0442d5ea44
push id24195
push userMs2ger@gmail.com
push dateSat, 19 Jan 2013 16:10:11 +0000
treeherderautoland@02e12a80aef9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones
bugs710989
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 710989 - Fix possible memset underflow in Time::Explode(). r=cjones
ipc/chromium/src/base/time_win.cc
--- a/ipc/chromium/src/base/time_win.cc
+++ b/ipc/chromium/src/base/time_win.cc
@@ -190,17 +190,17 @@ void Time::Explode(bool is_local, Explod
     success = FileTimeToLocalFileTime(&utc_ft, &ft);
   else
     ft = utc_ft;
 
   // FILETIME in SYSTEMTIME (exploded).
   SYSTEMTIME st;
   if (!success || !FileTimeToSystemTime(&ft, &st)) {
     NOTREACHED() << "Unable to convert time, don't know why";
-    ZeroMemory(exploded, sizeof(exploded));
+    ZeroMemory(exploded, sizeof(*exploded));
     return;
   }
 
   exploded->year = st.wYear;
   exploded->month = st.wMonth;
   exploded->day_of_week = st.wDayOfWeek;
   exploded->day_of_month = st.wDay;
   exploded->hour = st.wHour;