Backed out changeset f45123dd0cce (bug 1700141) for causing bc failures in browser_parsable_css.js
authorAlexandru Michis <malexandru@mozilla.com>
Thu, 01 Apr 2021 19:20:31 +0300
changeset 574027 49d2793258e9f91302a2000ba883de15483ecfa8
parent 574026 9e717f873bad77ac555ae7497a76b290ca40ad19
child 574028 37b71d8c65ed54441936d0e5ae39630b06ad3113
push id140003
push usermalexandru@mozilla.com
push dateThu, 01 Apr 2021 16:20:59 +0000
treeherderautoland@49d2793258e9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1700141
milestone89.0a1
backs outf45123dd0cced6a2340e296340e04f54f11cd7d4
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset f45123dd0cce (bug 1700141) for causing bc failures in browser_parsable_css.js CLOSED TREE
browser/themes/shared/preferences/preferences.inc.css
toolkit/themes/shared/checkbox.inc.css
toolkit/themes/shared/in-content/common.inc.css
--- a/browser/themes/shared/preferences/preferences.inc.css
+++ b/browser/themes/shared/preferences/preferences.inc.css
@@ -111,18 +111,18 @@ menuitem > label,
 button > hbox > label {
   line-height: unset;
 }
 
 .indent {
   margin-inline-start: 28px !important;
 }
 
-xul|checkbox {
-  margin-inline: 0;
+.checkbox-check {
+  margin-inline-end: 8px;
 }
 
 .tail-with-learn-more {
   margin-inline: 0 10px;
 }
 
 /* Add a bit of space to the end of descriptions to
  * leave margin with e.g. additional buttons on the side. */
--- a/toolkit/themes/shared/checkbox.inc.css
+++ b/toolkit/themes/shared/checkbox.inc.css
@@ -45,24 +45,20 @@ checkbox:not([disabled="true"]):hover > 
 
 checkbox:not([disabled="true"]):hover:active > .checkbox-check {
   background-color: var(--checkbox-unchecked-active-bgcolor, color-mix(in srgb, -moz-accent-color 8%, Field));
 }
 
 .checkbox-check[checked] {
   border-color: var(--checkbox-checked-border-color, transparent);
   background-color: var(--checkbox-checked-bgcolor, -moz-accent-color);
-  background-image: url("chrome://global/skin/icons/check.svg");
-  background-position: center;
-  background-repeat: no-repeat;
+  list-style-image: url("chrome://global/skin/icons/check.svg");
   -moz-context-properties: fill;
   fill: currentColor;
   color: var(--checkbox-checked-color, -moz-accent-color-foreground);
-  /* Style the button also when printing with "Print Backgrounds" unchecked */
-  color-adjust: exact;
 }
 
 checkbox:not([disabled="true"]):hover > .checkbox-check[checked] {
   background-color: var(--checkbox-checked-hover-bgcolor, color-mix(in srgb, currentColor 12.5%, -moz-accent-color));
 }
 
 checkbox:not([disabled="true"]):hover:active > .checkbox-check[checked] {
   background-color: var(--checkbox-checked-active-bgcolor, color-mix(in srgb, currentColor 25%, -moz-accent-color));
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -53,25 +53,16 @@
   --in-content-table-header-background: #0a84ff;
   --in-content-dialog-header-background: #f1f1f1;
   --in-content-sidebar-width: 240px;
 
   --dialog-warning-text-color: var(--red-60);
 
   --panel-border-radius: 2px; /* This is overridden on Windows */
 
-  --checkbox-border-color: rgb(143,143,157);
-  --checkbox-unchecked-bgcolor: rgb(240,240,244);
-  --checkbox-unchecked-hover-bgcolor: rgb(224,224,230);
-  --checkbox-unchecked-active-bgcolor: rgb(207,207,216);
-  --checkbox-checked-bgcolor: rgb(0,97,224);
-  --checkbox-checked-color: rgb(251,251,254);
-  --checkbox-checked-hover-bgcolor: rgb(2,80,187);
-  --checkbox-checked-active-bgcolor: rgb(5,62,148);
-
   --blue-40: #45a1ff;
   --blue-40-a10: rgb(69, 161, 255, 0.1);
   --blue-50: #0a84ff;
   --blue-50-a30: rgba(10, 132, 255, 0.3);
   --blue-60: #0060df;
   --blue-70: #003eaa;
   --blue-80: #002275;
   --grey-20: #ededf0;
@@ -177,24 +168,16 @@
     --in-content-link-color-hover: var(--in-content-primary-button-background-hover);
     --in-content-link-color-active: var(--in-content-primary-button-background-active);
     --in-content-link-color-visited: var(--in-content-link-color);
 
     --card-outline-color: var(--grey-60);
 
     --dialog-warning-text-color: var(--red-40);
 
-    --checkbox-unchecked-bgcolor: rgb(43, 42, 51);
-    --checkbox-unchecked-hover-bgcolor: rgb(82, 82, 94);
-    --checkbox-unchecked-active-bgcolor: rgb(91, 91, 102);
-    --checkbox-checked-bgcolor: rgb(0, 221, 255);
-    --checkbox-checked-color: rgb(43, 42, 51);
-    --checkbox-checked-hover-bgcolor: rgb(128, 235, 255);
-    --checkbox-checked-active-bgcolor: rgb(170, 242, 255);
-
     scrollbar-color: rgba(249,249,250,.4) rgba(20,20,25,.3);
   }
 }
 
 @supports not -moz-bool-pref("browser.proton.enabled") {
 @media (prefers-color-scheme: dark) {
   :host,
   :root {
@@ -603,18 +586,56 @@ html|input:is([type="email"], [type="tel
 html|textarea:focus,
 xul|search-textbox[focused] {
   box-shadow: 0 0 0 4px var(--blue-50-a30);
 }
 html|input:is([type="email"], [type="tel"], [type="text"], [type="password"], [type="url"], [type="number"]):-moz-ui-invalid,
 html|textarea:-moz-ui-invalid {
   box-shadow: 0 0 0 4px var(--red-50-a30);
 }
+} /*** END !proton ***/
 
-/** Pre-Proton XUL and HTML checkboxes **/
+html|input:is([type="email"], [type="tel"], [type="text"], [type="password"], [type="url"], [type="number"]):disabled,
+html|textarea:disabled,
+xul|search-textbox[disabled="true"] {
+  opacity: 0.4;
+}
+
+/* Links */
+
+html|a,
+.text-link {
+  color: var(--in-content-link-color);
+  text-decoration: none;
+}
+
+html|a:hover,
+.text-link:hover {
+  color: var(--in-content-link-color-hover);
+  text-decoration: underline;
+}
+
+html|a:visited {
+  color: var(--in-content-link-color-visited);
+}
+
+html|a:hover:active,
+.text-link:hover:active {
+  color: var(--in-content-link-color-active);
+  text-decoration: none;
+}
+
+html|a:-moz-focusring,
+.text-link:-moz-focusring {
+  outline: 2px solid var(--in-content-focus-outline-color);
+  outline-offset: 1px;
+  -moz-outline-radius: 2px;
+}
+
+/* Checkboxes and radio buttons */
 
 xul|checkbox {
   appearance: none;
   height: 30px;
   margin: 2px 0;
 }
 
 xul|*.checkbox-check,
@@ -667,104 +688,16 @@ xul|checkbox:not([disabled="true"])[chec
 html|input[type="checkbox"]:enabled:checked:hover {
   background-color: var(--in-content-primary-button-background-hover);
 }
 
 xul|checkbox:not([disabled="true"])[checked]:hover:active > xul|*.checkbox-check,
 html|input[type="checkbox"]:enabled:checked:hover:active {
   background-color: var(--in-content-primary-button-background-active);
 }
-} /*** END !proton ***/
-
-html|input:is([type="email"], [type="tel"], [type="text"], [type="password"], [type="url"], [type="number"]):disabled,
-html|textarea:disabled,
-xul|search-textbox[disabled="true"] {
-  opacity: 0.4;
-}
-
-/* Links */
-
-html|a,
-.text-link {
-  color: var(--in-content-link-color);
-  text-decoration: none;
-}
-
-html|a:hover,
-.text-link:hover {
-  color: var(--in-content-link-color-hover);
-  text-decoration: underline;
-}
-
-html|a:visited {
-  color: var(--in-content-link-color-visited);
-}
-
-html|a:hover:active,
-.text-link:hover:active {
-  color: var(--in-content-link-color-active);
-  text-decoration: none;
-}
-
-html|a:-moz-focusring,
-.text-link:-moz-focusring {
-  outline: 2px solid var(--in-content-focus-outline-color);
-  outline-offset: 1px;
-  -moz-outline-radius: 2px;
-}
-
-/* Checkboxes and radio buttons */
-
-@supports -moz-bool-pref("browser.proton.enabled") {
-/* Add invisible vertical click-target */
-xul|*.checkbox-check,
-html|input[type="checkbox"] {
-  margin-block: 2px;
-}
-
-html|input[type="checkbox"] {
-  appearance: none;
-  height: 16px;
-  width: 16px;
-  border: 1px solid var(--checkbox-border-color);
-  background-color: var(--checkbox-unchecked-bgcolor);
-  border-radius: 2px;
-  margin-inline-end: 6px;
-  flex-shrink: 0; /* avoid shrinking inside flex container */
-}
-
-html|input[type="checkbox"]:enabled:hover {
-  background-color: var(--checkbox-unchecked-hover-bgcolor);
-}
-
-html|input[type="checkbox"]:enabled:hover:active {
-  background-color: var(--checkbox-unchecked-active-bgcolor);
-}
-
-html|input[type="checkbox"]:checked {
-  border-color: var(--checkbox-checked-border-color);
-  background-color: var(--checkbox-checked-bgcolor);
-  background-image: url("chrome://global/skin/icons/check.svg");
-  background-position: center;
-  background-repeat: no-repeat;
-  -moz-context-properties: fill;
-  fill: currentColor;
-  color: var(--checkbox-checked-color);
-  /* Style the button also when printing with "Print Backgrounds" unchecked */
-  color-adjust: exact;
-}
-
-html|input[type="checkbox"]:enabled:checked:hover {
-  background-color: var(--checkbox-checked-hover-bgcolor);
-}
-
-html|input[type="checkbox"]:enabled:checked:hover:active {
-  background-color: var(--checkbox-checked-active-bgcolor);
-}
-} /** END Proton **/
 
 xul|richlistitem > xul|*.checkbox-check {
   margin: 3px 6px;
 }
 
 html|*.radio-container-with-text,
 html|*.toggle-container-with-text {
   display: flex;