Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge
authorMark Hammond <mhammond@skippinet.com.au>
Tue, 25 Oct 2016 13:47:33 +1100
changeset 319344 49a1469f39a3657051574ae8694ec0a668445a83
parent 319343 8c292af719239caae402b4f27e4d010ddd26e5bb
child 319345 a7e827f90ba93a2cee7d6956447b3a7447cfa408
push id33533
push usermhammond@skippinet.com.au
push dateWed, 26 Oct 2016 02:02:22 +0000
treeherderautoland@49a1469f39a3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskitcambridge
bugs1312642
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge MozReview-Commit-ID: 4EsnU7LSWDG
toolkit/components/places/PlacesSyncUtils.jsm
--- a/toolkit/components/places/PlacesSyncUtils.jsm
+++ b/toolkit/components/places/PlacesSyncUtils.jsm
@@ -123,17 +123,18 @@ const BookmarkSyncUtils = PlacesSyncUtil
     }
     let parentGuid = BookmarkSyncUtils.syncIdToGuid(parentSyncId);
     if (parentGuid == PlacesUtils.bookmarks.rootGuid) {
       // Reordering roots doesn't make sense, but Sync will do this on the
       // first sync.
       return undefined;
     }
     let orderedChildrenGuids = childSyncIds.map(BookmarkSyncUtils.syncIdToGuid);
-    return PlacesUtils.bookmarks.reorder(parentGuid, orderedChildrenGuids);
+    return PlacesUtils.bookmarks.reorder(parentGuid, orderedChildrenGuids,
+                                         { source: SOURCE_SYNC });
   }),
 
   /**
    * Removes an item from the database. Options are passed through to
    * PlacesUtils.bookmarks.remove.
    */
   remove: Task.async(function* (syncId, options = {}) {
     let guid = BookmarkSyncUtils.syncIdToGuid(syncId);