Bug 931445 - Part 5 - Avoid childIframe subtest to be started twice. r=smaug
authorXidorn Quan <me@upsuper.org>
Wed, 03 Aug 2016 15:14:49 +1000
changeset 308246 469adeba9212c33ed9855a3810299d6d523c8b17
parent 308245 d7523c05343df10f6162edb57188846677004864
child 308247 1fcb956172cd2bdc802f3a71950244525f3fc20a
push id31092
push usercbook@mozilla.com
push dateFri, 05 Aug 2016 10:16:59 +0000
treeherderautoland@b97dd7dd3cb9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs931445
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 931445 - Part 5 - Avoid childIframe subtest to be started twice. r=smaug This is a silly bug that start() is called twice in this subtest, one from the load event of the document (by pointerlock_utils.js), the other is by onload of the iframe. Given the document's load event comes later, I removed the onload of iframe. MozReview-Commit-ID: 7TQJVa3xCb9
dom/tests/mochitest/pointerlock/file_childIframe.html
dom/tests/mochitest/pointerlock/mochitest.ini
--- a/dom/tests/mochitest/pointerlock/file_childIframe.html
+++ b/dom/tests/mochitest/pointerlock/file_childIframe.html
@@ -32,17 +32,17 @@ https://bugzilla.mozilla.org/show_bug.cg
   <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=633602">
     Mozilla Bug 633602
   </a>
 
   <div id="parent">
     <table id="childTable">
       <tr>
         <td>
-          <iframe id="iframe" src="iframe_differentDOM.html" onload="start();">
+          <iframe id="iframe" src="iframe_differentDOM.html">
           </iframe>
         </td>
         <td>
           <div id="childDiv">
           </div>
         </td>
       </tr>
     </table>
--- a/dom/tests/mochitest/pointerlock/mochitest.ini
+++ b/dom/tests/mochitest/pointerlock/mochitest.ini
@@ -18,9 +18,9 @@ support-files =
   file_suppressSomeMouseEvents.html
   file_locksvgelement.html
   file_allowPointerLockSandboxFlag.html
   file_changeLockElement.html
   iframe_differentDOM.html
 
 [test_pointerlock-api.html]
 tags = fullscreen
-skip-if = buildapp == 'b2g' || toolkit == 'android' || os == 'win' # B2G - window.open focus issues using fullscreen. Win: Bug 931445
+skip-if = buildapp == 'b2g' || toolkit == 'android' # B2G - window.open focus issues using fullscreen.