Bug 1395900 part 3 - Remove unused IonBuilder::nonStringIteration_. r=tcampbell
authorJan de Mooij <jdemooij@mozilla.com>
Wed, 06 Sep 2017 10:02:09 +0200
changeset 379335 456b4480fdbfc310c322407e9a4125624530f12e
parent 379334 fdc73e6b6a213edf515fd5a28db8ed0fa892766e
child 379336 57a63c3f76fba9d1bc379eafbc564dc7226bd40e
push id50642
push userarchaeopteryx@coole-files.de
push dateThu, 07 Sep 2017 10:41:07 +0000
treeherderautoland@bd0ce93776fe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstcampbell
bugs1395900
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1395900 part 3 - Remove unused IonBuilder::nonStringIteration_. r=tcampbell
js/src/jit/IonBuilder.cpp
js/src/jit/IonBuilder.h
--- a/js/src/jit/IonBuilder.cpp
+++ b/js/src/jit/IonBuilder.cpp
@@ -151,17 +151,16 @@ IonBuilder::IonBuilder(JSContext* analys
 #endif
     inspector(inspector),
     inliningDepth_(inliningDepth),
     inlinedBytecodeLength_(0),
     numLoopRestarts_(0),
     failedBoundsCheck_(info->script()->failedBoundsCheck()),
     failedShapeGuard_(info->script()->failedShapeGuard()),
     failedLexicalCheck_(info->script()->failedLexicalCheck()),
-    nonStringIteration_(false),
 #ifdef DEBUG
     hasLazyArguments_(false),
 #endif
     inlineCallInfo_(nullptr),
     maybeFallbackFunctionGetter_(nullptr)
 {
     script_ = info->script();
     scriptHasIonScript_ = script_->hasIonScript();
@@ -12570,19 +12569,16 @@ IonBuilder::jsop_toid()
     current->push(ins);
 
     return resumeAfter(ins);
 }
 
 AbortReasonOr<Ok>
 IonBuilder::jsop_iter(uint8_t flags)
 {
-    if (flags != JSITER_ENUMERATE)
-        nonStringIteration_ = true;
-
     MDefinition* obj = current->pop();
     MInstruction* ins = MGetIteratorCache::New(alloc(), obj);
 
     if (!outermostBuilder()->iterators_.append(ins))
         return abort(AbortReason::Alloc);
 
     current->add(ins);
     current->push(ins);
--- a/js/src/jit/IonBuilder.h
+++ b/js/src/jit/IonBuilder.h
@@ -1075,19 +1075,16 @@ class IonBuilder
     // True if script->failedShapeGuard is set for the current script or
     // an outer script.
     bool failedShapeGuard_;
 
     // True if script->failedLexicalCheck_ is set for the current script or
     // an outer script.
     bool failedLexicalCheck_;
 
-    // Has an iterator other than 'for in'.
-    bool nonStringIteration_;
-
 #ifdef DEBUG
     // If this script uses the lazy arguments object.
     bool hasLazyArguments_;
 #endif
 
     // If this is an inline builder, the call info for the builder.
     const CallInfo* inlineCallInfo_;