bug 1598286: toolkit: enable remote agent on Windows AArch64; r=remote-protocol-reviewers,whimboo,froydnj
authorAndreas Tolfsen <ato@sny.no>
Mon, 06 Jan 2020 14:24:15 +0000
changeset 509107 4558b24acb30bea7a8d0e9862a2e85e64ae65d4c
parent 509106 2965d6589d90cab06f93bb8b2a455eaf6eda0e8a
child 509108 11720a001804557edfb753d7b8c54160088b8ec6
push id104443
push useratolfsen@mozilla.com
push dateTue, 07 Jan 2020 13:49:46 +0000
treeherderautoland@4558b24acb30 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersremote-protocol-reviewers, whimboo, froydnj
bugs1598286, 1606935, 1603930
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1598286: toolkit: enable remote agent on Windows AArch64; r=remote-protocol-reviewers,whimboo,froydnj The remote agent used to not compile on Windows AArch64 due to iovec's dependency on a version of winapi without support for this architecture. Now that the remote agent has upgraded to http 0.2, which depends on a version of the bytes crate that has moved away from iovec in favour of std::io::IoSlice, we are able to turn on support for Windows AArch64. This in turn will also fix bug 1606935 because the browser-chrome test manifest for M(remote) will no longer be empty. It was a regression caused by 1603930 where we fixed a logic error causnig ENABLE_REMOTE_AGENT to be inappropriately set on non-trunk branches. Differential Revision: https://phabricator.services.mozilla.com/D58767
toolkit/moz.configure
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -930,21 +930,16 @@ add_old_configure_assignment('FT2_CFLAGS
 # The source code lives under ../remote.
 
 @depends(target, build_project, milestone)
 def remote_default(target, project, milestone):
     # no support for Android
     if target.os == 'Android':
         return False
 
-    # winapi 0.2.8 does not work on AArch64
-    # TODO(ato): https://bugzil.la/1598286
-    if target.os == 'WINNT' and target.cpu == 'aarch64':
-        return False
-
     # enable on Firefox Nightly channel only
     # TODO(ato): https://bugzil.la/1544393
     return project == 'browser' and milestone.is_nightly
 
 option('--enable-cdp', default=remote_default,
        help='{Enable|Disable} remote agent')
 
 @depends('--enable-cdp')