Bug 1476009: Remove unnecessary initialization. r=mak
authorRobert Bartlensky <rbartlensky@mozilla.com>
Mon, 16 Jul 2018 17:56:02 +0100
changeset 427129 44fd25e3d484
parent 427128 c0585180a0c3
child 427130 c67bdec5c592
push id66523
push useraiakab@mozilla.com
push dateWed, 18 Jul 2018 14:09:09 +0000
treeherderautoland@44fd25e3d484 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak
bugs1476009
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476009: Remove unnecessary initialization. r=mak MozReview-Commit-ID: LyDzKB6gein
storage/mozStorageHelper.h
--- a/storage/mozStorageHelper.h
+++ b/storage/mozStorageHelper.h
@@ -149,17 +149,17 @@ public:
   nsresult Rollback()
   {
     if (!mConnection || mCompleted || !mHasTransaction)
       return NS_OK;
     mCompleted = true;
 
     // TODO (bug 1062823): from Sqlite 3.7.11 on, rollback won't ever return
     // a busy error, so this handling can be removed.
-    nsresult rv = NS_OK;
+    nsresult rv;
     do {
       rv = mConnection->ExecuteSimpleSQL(NS_LITERAL_CSTRING("ROLLBACK"));
       if (rv == NS_ERROR_STORAGE_BUSY)
         (void)PR_Sleep(PR_INTERVAL_NO_WAIT);
     } while (rv == NS_ERROR_STORAGE_BUSY);
 
     if (NS_SUCCEEDED(rv))
       mHasTransaction = false;