Bug 1634947 - Update the TLS deprecated error message in Firefox. r=johannh,necko-reviewers,valentin
authorprathiksha <prathikshaprasadsuman@gmail.com>
Wed, 27 May 2020 21:58:30 +0000
changeset 532623 41522eadf227f0be54489c1dee4804827a4275f6
parent 532622 b8092c1039a4314ba22473a81913f11bc8c5cb8f
child 532624 7610307d40316f253efcda42fe5939baf100efb2
push id117283
push userprathikshaprasadsuman@gmail.com
push dateWed, 27 May 2020 22:01:56 +0000
treeherderautoland@41522eadf227 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh, necko-reviewers, valentin
bugs1634947
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1634947 - Update the TLS deprecated error message in Firefox. r=johannh,necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D77021
devtools/client/webconsole/test/browser/browser_webconsole_certificate_messages.js
dom/locales/en-US/chrome/security/security.properties
netwerk/protocol/http/nsHttpChannel.cpp
--- a/devtools/client/webconsole/test/browser/browser_webconsole_certificate_messages.js
+++ b/devtools/client/webconsole/test/browser/browser_webconsole_certificate_messages.js
@@ -12,19 +12,18 @@ const TEST_URI_PATH =
   "browser/test-certificate-messages.html";
 
 const SHA1_URL = "https://sha1ee.example.com" + TEST_URI_PATH;
 const SHA256_URL = "https://sha256ee.example.com" + TEST_URI_PATH;
 const TRIGGER_MSG = "If you haven't seen ssl warnings yet, you won't";
 const TLS_1_0_URL = "https://tls1.example.com" + TEST_URI_PATH;
 
 const TLS_expected_message =
-  "This site uses a deprecated version of TLS that" +
-  " will be disabled in March 2020. Please upgrade" +
-  " to TLS 1.2 or 1.3.";
+  "This site uses a deprecated version of TLS. " +
+  "Please upgrade to TLS 1.2 or 1.3.";
 
 registerCleanupFunction(function() {
   // Set preferences back to their original values
   Services.prefs.clearUserPref("security.tls.version.min");
   Services.prefs.clearUserPref("security.tls.version.max");
 });
 
 add_task(async function() {
--- a/dom/locales/en-US/chrome/security/security.properties
+++ b/dom/locales/en-US/chrome/security/security.properties
@@ -62,17 +62,17 @@ IneligibleResource=“%1$S” is not eligible for integrity checks since it’s neither CORS-enabled nor same-origin.
 # LOCALIZATION NOTE: Do not translate "integrity". "%1$S" is the invalid hash algorithm found in the attribute.
 UnsupportedHashAlg=Unsupported hash algorithm in the integrity attribute: “%1$S”
 # LOCALIZATION NOTE: Do not translate "integrity"
 NoValidMetadata=The integrity attribute does not contain any valid metadata.
 
 # LOCALIZATION NOTE: Do not translate "RC4".
 WeakCipherSuiteWarning=This site uses the cipher RC4 for encryption, which is deprecated and insecure.
 
-DeprecatedTLSVersion=This site uses a deprecated version of TLS that will be disabled in March 2020. Please upgrade to TLS 1.2 or 1.3.
+DeprecatedTLSVersion2=This site uses a deprecated version of TLS. Please upgrade to TLS 1.2 or 1.3.
 
 #XCTO: nosniff
 # LOCALIZATION NOTE: Do not translate "X-Content-Type-Options: nosniff".
 MimeTypeMismatch2=The resource from “%1$S” was blocked due to MIME type (“%2$S”) mismatch (X-Content-Type-Options: nosniff).
 # LOCALIZATION NOTE: Do not translate "X-Content-Type-Options" and also do not translate "nosniff".
 XCTOHeaderValueMissing=X-Content-Type-Options header warning: value was “%1$S”; did you mean to send “nosniff”?
 # LOCALIZATION NOTE: Do not translate "X-Content-Type-Options" and also do not translate "nosniff".
 XTCOWithMIMEValueMissing=The resource from “%1$S” was not rendered due to an unknown, incorrect or missing MIME type (X-Content-Type-Options: nosniff).
--- a/netwerk/protocol/http/nsHttpChannel.cpp
+++ b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -2373,17 +2373,17 @@ void nsHttpChannel::ProcessSSLInformatio
     }
   }
 
   uint16_t tlsVersion;
   nsresult rv = securityInfo->GetProtocolVersion(&tlsVersion);
   if (NS_SUCCEEDED(rv) &&
       tlsVersion != nsITransportSecurityInfo::TLS_VERSION_1_2 &&
       tlsVersion != nsITransportSecurityInfo::TLS_VERSION_1_3) {
-    nsString consoleErrorTag = NS_LITERAL_STRING("DeprecatedTLSVersion");
+    nsString consoleErrorTag = NS_LITERAL_STRING("DeprecatedTLSVersion2");
     nsString consoleErrorCategory = NS_LITERAL_STRING("TLS");
     Unused << AddSecurityMessage(consoleErrorTag, consoleErrorCategory);
   }
 }
 
 void nsHttpChannel::ProcessAltService() {
   // e.g. Alt-Svc: h2=":443"; ma=60
   // e.g. Alt-Svc: h2="otherhost:443"