Bug 1566465 - Fix crash in Http2Session::RecvAltSvc. r=dragana
authorChristian Holler <choller@mozilla.com>
Wed, 31 Jul 2019 07:51:05 +0000
changeset 485600 3c6c96c10ba41a91b8ea9130c05ebfbe9730e803
parent 485599 f245cd44c403ae536656c123856a82a1991610ad
child 485601 ab146dc0cde6d3dbcaf7bf914e204af2a0faa4b7
push id91344
push usercholler@mozilla.com
push dateWed, 31 Jul 2019 15:09:32 +0000
treeherderautoland@3c6c96c10ba4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdragana
bugs1566465
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1566465 - Fix crash in Http2Session::RecvAltSvc. r=dragana Differential Revision: https://phabricator.services.mozilla.com/D38197
netwerk/protocol/http/Http2Session.cpp
--- a/netwerk/protocol/http/Http2Session.cpp
+++ b/netwerk/protocol/http/Http2Session.cpp
@@ -2617,16 +2617,17 @@ nsresult Http2Session::RecvAltSvc(Http2S
     if (!origin.IsEmpty()) {
       LOG(("Http2Session %p Alt-Svc pulled stream has non empty origin\n",
            self));
       self->ResetDownstreamState();
       return NS_OK;
     }
 
     if (NS_FAILED(self->SetInputFrameDataStream(self->mInputFrameID)) ||
+        !self->mInputFrameDataStream ||
         !self->mInputFrameDataStream->Transaction() ||
         !self->mInputFrameDataStream->Transaction()->RequestHead()) {
       LOG3(
           ("Http2Session::RecvAltSvc %p got frame w/o origin on invalid stream",
            self));
       self->ResetDownstreamState();
       return NS_OK;
     }