Bug 1705526 [wpt PR 28526] - Always add consumed block-size when calculating legacy static pos., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Fri, 23 Apr 2021 10:20:10 +0000
changeset 577265 3aa2e813a4e3b2ae70351c636e7226f8d8bd3012
parent 577264 128bb9ccf9c9da8e4c55388779c39e01b38e2092
child 577266 a9fd5930d73fbcaae35293da6a3e0efda9371ec1
push id141827
push userwptsync@mozilla.com
push dateSat, 24 Apr 2021 02:11:12 +0000
treeherderautoland@3a7d9d49c316 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1705526, 28526, 1199258, 2826460, 873069
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1705526 [wpt PR 28526] - Always add consumed block-size when calculating legacy static pos., a=testonly Automatic update from web-platform-tests Always add consumed block-size when calculating legacy static pos. We used to do it only when the parent of an OOF was a fragmentainer, but this is always needed for any descendant as well. The legacy code in LayoutBox::ComputeInlineStaticDistance() expects the block-offset to be relative to the parent in the flow thread coordinate space. Also initialize previous_break_token_ to nullptr. This was a mistake during oilpan conversion, which suddenly became a problem (it may have been safe-ish before, but not anymore). The new test abspos-autopos-contained-by-viewport-001.html would fail without this fix. Bug: 1199258 Change-Id: I7520cad9112485e908df3be33b354aec58332db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826460 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#873069} -- wpt-commits: ac12ed34d2b923cac8af08055036679c3a080afb wpt-pr: 28526
testing/web-platform/tests/css/css-multicol/abspos-autopos-contained-by-viewport-000.html
testing/web-platform/tests/css/css-multicol/abspos-autopos-contained-by-viewport-001.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-multicol/abspos-autopos-contained-by-viewport-000.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-multicol-1/">
+<link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#abs-non-replaced-height">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="columns:2; column-gap:0; column-fill:auto; width:100px; height:100px; background:red;">
+  <div style="height:120px; background:green;"></div>
+  <div style="position:absolute; width:50px; height:80px; background:green;"></div>
+</div>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-multicol/abspos-autopos-contained-by-viewport-001.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-multicol-1/">
+<link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#abs-non-replaced-height">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="columns:2; column-gap:0; column-fill:auto; width:100px; height:100px; background:red;">
+  <div>
+    <div style="height:120px; background:green;"></div>
+    <div style="position:absolute; width:50px; height:80px; background:green;"></div>
+  </div>
+</div>