Bug 1638724 - Check for extension id instead of extension. r=esawin
authorAgi Sferro <agi@sferro.dev>
Tue, 07 Jul 2020 18:51:02 +0000
changeset 539192 39d2bb3d03b2314ea7baf8ccf5df0cd36c001c99
parent 539191 32e0f65d54b0aa64b3f2e9099adfd64af03b2572
child 539193 eb7361d2c45e42616bac32eec0bae4c55904c8c9
push id120988
push userasferro@mozilla.com
push dateTue, 07 Jul 2020 19:31:36 +0000
treeherderautoland@39d2bb3d03b2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersesawin
bugs1638724
milestone80.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1638724 - Check for extension id instead of extension. r=esawin Differential Revision: https://phabricator.services.mozilla.com/D82443
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/WebExtensionTest.kt
@@ -550,17 +550,17 @@ class WebExtensionTest : BaseSessionTest
     fun testBrowserTabsCreateWithCookieStoreId() {
         val tabsCreateResult = GeckoResult<Void>()
         var tabsExtension: WebExtension? = null
         val tabDelegate = object : WebExtension.TabDelegate {
             override fun onNewTab(source: WebExtension, details: WebExtension.CreateTabDetails): GeckoResult<GeckoSession> {
                 assertEquals(details.url, "https://www.mozilla.org/en-US/")
                 assertEquals(details.active, true)
                 assertEquals(details.cookieStoreId, "1")
-                assertEquals(tabsExtension!!, source)
+                assertEquals(tabsExtension!!.id, source.id)
                 tabsCreateResult.complete(null)
                 return GeckoResult.fromValue(null)
             }
         }
 
         tabsExtension = sessionRule.waitForResult(controller.installBuiltIn(TABS_CREATE_2_BACKGROUND))
         tabsExtension.setTabDelegate(tabDelegate)
         sessionRule.waitForResult(tabsCreateResult)