Bug 1481655. Don't add recordings of the hit test info to blob images. r=mstange
☠☠ backed out by 74910b7a444f ☠ ☠
authorJeff Muizelaar <jmuizelaar@mozilla.com>
Wed, 08 Aug 2018 17:32:52 +0000
changeset 430579 37ac6d023498780dd12fecb5acdc4c222d452505
parent 430578 f99759ea7410a44f5222889ee01bb0f0356f670b
child 430580 74910b7a444fbbdb6399a15e19593a3c30790eec
push id67523
push userjmuizelaar@mozilla.com
push dateWed, 08 Aug 2018 17:33:55 +0000
treeherderautoland@37ac6d023498 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1481655
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1481655. Don't add recordings of the hit test info to blob images. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D2938
gfx/layers/wr/WebRenderCommandBuilder.cpp
--- a/gfx/layers/wr/WebRenderCommandBuilder.cpp
+++ b/gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ -743,17 +743,19 @@ struct DIGroup
         MOZ_RELEASE_ASSERT(!data->mInvalid);
       }
 
       nsDisplayList* children = item->GetChildren();
       if (children) {
         GP("doing children in EndGroup\n");
         aGrouper->PaintContainerItem(this, item, bounds, children, aContext, aRecorder);
       } else {
-        if (dirty) {
+        // Hit test items don't have anything to paint so skip them. Ideally we
+        // would drop these items earlier...
+        if (dirty && item->Type() != DisplayItemType::TYPE_COMPOSITOR_HITTEST_INFO) {
           // What should the clip settting strategy be? We can set the full clip everytime.
           // this is probably easiest for now. An alternative would be to put the push and the pop
           // into separate items and let invalidation handle it that way.
           DisplayItemClip currentClip = item->GetClip();
 
           if (currentClip.HasClip()) {
             aContext->Save();
             currentClip.ApplyTo(aContext, aGrouper->mAppUnitsPerDevPixel);