Backed out changeset 7005723d76c7 (bug 1497280) for mochitest and bc failures on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Thu, 01 Nov 2018 22:35:42 +0200
changeset 443977 37545337e03d
parent 443976 2ed53dbf2b95
child 443978 f66fc2252f52
push id72181
push userapavel@mozilla.com
push dateThu, 01 Nov 2018 20:36:09 +0000
treeherderautoland@37545337e03d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1497280
milestone65.0a1
backs out7005723d76c7
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 7005723d76c7 (bug 1497280) for mochitest and bc failures on a CLOSED TREE
toolkit/actors/DateTimePickerChild.jsm
toolkit/modules/ActorManagerParent.jsm
toolkit/modules/DateTimePickerParent.jsm
--- a/toolkit/actors/DateTimePickerChild.jsm
+++ b/toolkit/actors/DateTimePickerChild.jsm
@@ -84,17 +84,17 @@ class DateTimePickerChild extends ActorC
    */
   receiveMessage(aMessage) {
     switch (aMessage.name) {
       case "FormDateTime:PickerClosed": {
         this.close();
         break;
       }
       case "FormDateTime:PickerValueChanged": {
-        this._inputElement.updateDateTimeInputBox(aMessage.data.detail);
+        this._inputElement.updateDateTimeInputBox(aMessage.data);
         break;
       }
       default:
         break;
     }
   }
 
   /**
@@ -117,17 +117,17 @@ class DateTimePickerChild extends ActorC
           return;
         }
 
         this._inputElement = aEvent.originalTarget;
         this._inputElement.setDateTimePickerState(true);
         this.addListeners();
 
         let value = this._inputElement.getDateTimeInputBoxValue();
-        this.sendAsyncMessage("FormDateTime:OpenPicker", {
+        this.mm.sendAsyncMessage("FormDateTime:OpenPicker", {
           rect: this.getBoundingContentRect(this._inputElement),
           dir: this.getComputedDirection(this._inputElement),
           type: this._inputElement.type,
           detail: {
             // Pass partial value if it's available, otherwise pass input
             // element's value.
             value: Object.keys(value).length > 0 ? value
                                                  : this._inputElement.value,
@@ -137,28 +137,28 @@ class DateTimePickerChild extends ActorC
             stepBase: this._inputElement.getStepBase(),
           },
         });
         break;
       }
       case "MozUpdateDateTimePicker": {
         let value = this._inputElement.getDateTimeInputBoxValue();
         value.type = this._inputElement.type;
-        this.sendAsyncMessage("FormDateTime:UpdatePicker", { value });
+        this.mm.sendAsyncMessage("FormDateTime:UpdatePicker", { value });
         break;
       }
       case "MozCloseDateTimePicker": {
-        this.sendAsyncMessage("FormDateTime:ClosePicker");
+        this.mm.sendAsyncMessage("FormDateTime:ClosePicker");
         this.close();
         break;
       }
       case "pagehide": {
         if (this._inputElement &&
             this._inputElement.ownerDocument == aEvent.target) {
-          this.sendAsyncMessage("FormDateTime:ClosePicker");
+          this.mm.sendAsyncMessage("FormDateTime:ClosePicker");
           this.close();
         }
         break;
       }
       default:
         break;
     }
   }
--- a/toolkit/modules/ActorManagerParent.jsm
+++ b/toolkit/modules/ActorManagerParent.jsm
@@ -148,17 +148,16 @@ let ACTORS = {
   },
 
   DateTimePicker: {
     child: {
       module: "resource://gre/actors/DateTimePickerChild.jsm",
       events: {
         "MozOpenDateTimePicker": {},
       },
-      allFrames: true,
     },
   },
 
   ExtFind: {
     child: {
       module: "resource://gre/actors/ExtFindChild.jsm",
       messages: [
         "ext-Finder:CollectResults",
--- a/toolkit/modules/DateTimePickerParent.jsm
+++ b/toolkit/modules/DateTimePickerParent.jsm
@@ -79,54 +79,48 @@ var DateTimePickerParent = {
     switch (aEvent.type) {
       case "DateTimePickerValueChanged": {
         this.updateInputBoxValue(aEvent);
         break;
       }
       case "popuphidden": {
         let browser = this.weakBrowser ? this.weakBrowser.get() : null;
         if (browser) {
-          browser.messageManager.sendAsyncMessage("FormDateTime:PickerClosed", {
-            browsingContextId: this._browsingContextId,
-          });
+          browser.messageManager.sendAsyncMessage("FormDateTime:PickerClosed");
         }
         this.picker.closePicker();
         this.close();
         break;
       }
       default:
         break;
     }
   },
 
   // Called when picker value has changed, notify input box about it.
   updateInputBoxValue(aEvent) {
     let browser = this.weakBrowser ? this.weakBrowser.get() : null;
     if (browser) {
       browser.messageManager.sendAsyncMessage(
-        "FormDateTime:PickerValueChanged", {
-          detail: aEvent.detail,
-          browsingContextId: this._browsingContextId,
-        });
+        "FormDateTime:PickerValueChanged", aEvent.detail);
     }
   },
 
   // Get picker from browser and show it anchored to the input box.
   async showPicker(aBrowser, aData) {
     let rect = aData.rect;
     let type = aData.type;
     let detail = aData.detail;
 
     this._anchor = aBrowser.ownerGlobal.gBrowser.popupAnchor;
     this._anchor.left = rect.left;
     this._anchor.top = rect.top;
     this._anchor.width = rect.width;
     this._anchor.height = rect.height;
     this._anchor.hidden = false;
-    this._browsingContextId = aData.browsingContextId;
 
     debug("Opening picker with details: " + JSON.stringify(detail));
 
     let window = aBrowser.ownerGlobal;
     let tabbrowser = window.gBrowser;
     if (Services.focus.activeWindow != window ||
         tabbrowser.selectedBrowser != aBrowser) {
       // We were sent a message from a window or tab that went into the