Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r=jya
authorGerald Squelart <gsquelart@mozilla.com>
Fri, 24 Mar 2017 16:37:45 +1100
changeset 352559 374eac537a5e77e259a9fe6f356538f4ab8f0337
parent 352558 5ff6265b06bf8e96bbef0a6c35c29930b62422d6
child 352560 19baf99d6ad981419b03f1a5c3eea91ddb3582b0
push id40580
push usergsquelart@mozilla.com
push dateWed, 12 Apr 2017 10:36:38 +0000
treeherderautoland@ef27dccaf311 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1343442
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r=jya We want the new MediaDecodeError messages to be forwarded to the front-end in browser-media.js (even though they won't be handled just yet; an upcoming patch will add the handling code). This is limited to Nightly for now, like the "Report Site Issues" button, because we forward URLs to webcompat.com (at the user's request). And MediaDecodeWarning was not added, as it may cause too much annoyance, but it is available for testers to get more diagnostics information if needed. MozReview-Commit-ID: HPDpA1mg4HX
modules/libpref/init/all.js
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -380,17 +380,21 @@ pref("media.apple.mp4.enabled", true);
 // media.gmp.storage.version.observed, and if the versions don't match,
 // we clear storage and set media.gmp.storage.version.observed=expected.
 // This provides a mechanism to clear GMP storage when non-compatible
 // changes are made.
 pref("media.gmp.storage.version.expected", 1);
 
 // Filter what triggers user notifications.
 // See DecoderDoctorDocumentWatcher::ReportAnalysis for details.
+#ifdef NIGHTLY_BUILD
+pref("media.decoder-doctor.notifications-allowed", "MediaWMFNeeded,MediaWidevineNoWMF,MediaCannotInitializePulseAudio,MediaCannotPlayNoDecoders,MediaUnsupportedLibavcodec,MediaDecodeError");
+#else
 pref("media.decoder-doctor.notifications-allowed", "MediaWMFNeeded,MediaWidevineNoWMF,MediaCannotInitializePulseAudio,MediaCannotPlayNoDecoders,MediaUnsupportedLibavcodec");
+#endif
 // Whether we report partial failures.
 pref("media.decoder-doctor.verbose", false);
 // Whether DD should consider WMF-disabled a WMF failure, useful for testing.
 pref("media.decoder-doctor.wmf-disabled-is-failure", false);
 
 // Whether to suspend decoding of videos in background tabs.
 #ifdef NIGHTLY_BUILD
 pref("media.suspend-bkgnd-video.enabled", true);