Backed out changeset 06efcd8f9c0c (bug 1823791) for causing bc failures in browser_1795260_searchbar_overflow_toolbar.js CLOSED TREE
authorCristian Tuns <ctuns@mozilla.com>
Fri, 24 Mar 2023 11:33:02 -0400 (2023-03-24)
changeset 657871 36ae8bb2dcc6d2545c90f678851018d90335575e
parent 657870 0bb622ef411df07248b0d2df439ff5d22feca527
child 657872 7957a017e897d12e4a50ed5dcf6746d79a59f83a
push id181047
push userctuns@mozilla.com
push dateFri, 24 Mar 2023 15:33:24 +0000 (2023-03-24)
treeherderautoland@36ae8bb2dcc6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1823791
milestone113.0a1
backs out06efcd8f9c0c822285986946ee7815a8a19e3449
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 06efcd8f9c0c (bug 1823791) for causing bc failures in browser_1795260_searchbar_overflow_toolbar.js CLOSED TREE
browser/base/content/browser.css
browser/themes/shared/urlbar-searchbar.css
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -763,53 +763,55 @@ toolbar:not(#TabsToolbar) > #personal-bo
 
 /* We leave 310px plus whatever space the download and unified extensions
  * buttons will need when they *both* appear. Normally, for each button, this
  * should be 16px for the icon, plus 2 * 2px padding plus the
  * toolbarbutton-inner-padding. We're adding 4px to ensure things like rounding
  * on hidpi don't accidentally result in the buttons going into overflow.
  */
 #urlbar-container {
-  width: calc(310px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
+  min-width: calc(310px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
 }
 
 /* When the download button OR the unified extensions button is shown, we leave
  * 310px plus the space needed for a single button as described above. */
-#nav-bar:is([downloadsbuttonshown], [unifiedextensionsbuttonshown]) #urlbar-container {
-  width: calc(310px + 24px + 2 * var(--toolbarbutton-inner-padding));
+#nav-bar[downloadsbuttonshown] #urlbar-container,
+#nav-bar[unifiedextensionsbuttonshown] #urlbar-container {
+  min-width: calc(310px + 24px + 2 * var(--toolbarbutton-inner-padding));
 }
 
 /* When both the download and unified extensions buttons are visible, we use
  * the base min-width value. */
 #nav-bar[downloadsbuttonshown][unifiedextensionsbuttonshown] #urlbar-container {
-  width: 310px;
+  min-width: 310px;
 }
 
 /* Customize mode is difficult to use at moderate window width if the Urlbar
    remains 310px wide. */
 :root[customizing] #urlbar-container {
-  width: 280px;
+  min-width: 280px;
 }
 
 #identity-icon-box {
   max-width: calc(30px + 13em);
 }
 
 @media (max-width: 770px) {
   #urlbar-container {
-    width: calc(240px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
+    min-width: calc(240px + 2 * (24px + 2 * var(--toolbarbutton-inner-padding)));
   }
-  #nav-bar:is([downloadsbuttonshown], [unifiedextensionsbuttonshown]) #urlbar-container {
-    width: calc(240px + 24px + 2 * var(--toolbarbutton-inner-padding));
+  #nav-bar[downloadsbuttonshown] #urlbar-container,
+  #nav-bar[unifiedextensionsbuttonshown] #urlbar-container {
+    min-width: calc(240px + 24px + 2 * var(--toolbarbutton-inner-padding));
   }
   #nav-bar[downloadsbuttonshown][unifiedextensionsbuttonshown] #urlbar-container {
-    width: 240px;
+    min-width: 240px;
   }
   :root[customizing] #urlbar-container {
-    width: 245px;
+    min-width: 245px;
   }
   #identity-icon-box {
     max-width: 80px;
   }
   /* Contenxtual identity labels are user-customizable and can be very long,
      so we only show the colored icon when the window gets small. */
   #userContext-label {
     display: none;
--- a/browser/themes/shared/urlbar-searchbar.css
+++ b/browser/themes/shared/urlbar-searchbar.css
@@ -264,17 +264,17 @@
 }
 
 #urlbar-container {
   align-items: center;
 }
 
 #urlbar-container,
 #wrapper-urlbar-container {
-  flex: 400 0 auto;
+  flex: 400 400;
 }
 
 #urlbar-search-splitter {
   /* The splitter width should equal the location and search bars' combined
      neighboring margin and border width. */
   min-width: 12px;
   margin: 0 -6px;
   position: relative;
@@ -645,22 +645,21 @@
 #urlbar-zoom-button > .toolbarbutton-icon {
   display: none;
 }
 
 /* Search bar */
 
 #search-container {
   min-width: 125px;
-  width: 125px;
 }
 
 #search-container,
 #wrapper-search-container {
-  flex: 175 0 auto;
+  flex: 175 175;
 }
 
 #search-container[width] {
   /* Take something closer to the explicit width when requested. Also important
    * to use flex-basis auto so that the width is actually honored. */
   flex: 1 auto;
 }