Backed out changeset e367443dd417 (bug 1479316) fpor failure at devtools/client/responsive.html/test/browser/browser_favicon.js
authorDaniel Varga <dvarga@mozilla.com>
Thu, 09 Aug 2018 02:26:25 +0300
changeset 430594 35b70105cbe3962f28c0417d1d46ac400bb95dff
parent 430593 6d19dd7ed3e564b88ab5b962e90ebf73c21fc257
child 430595 e7eb8b37d85e58a3890867ffa4704dcf2085cdb7
push id67538
push userdvarga@mozilla.com
push dateWed, 08 Aug 2018 23:26:43 +0000
treeherderautoland@35b70105cbe3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1479316
milestone63.0a1
backs oute367443dd417aed7d28eb6eed8288c6361a50d6f
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e367443dd417 (bug 1479316) fpor failure at devtools/client/responsive.html/test/browser/browser_favicon.js
devtools/client/responsive.html/browser/tunnel.js
devtools/client/responsive.html/test/browser/browser.ini
devtools/client/responsive.html/test/browser/browser_favicon.js
devtools/client/responsive.html/test/browser/favicon.html
devtools/client/responsive.html/test/browser/favicon.ico
--- a/devtools/client/responsive.html/browser/tunnel.js
+++ b/devtools/client/responsive.html/browser/tunnel.js
@@ -376,20 +376,16 @@ MessageManagerTunnel.prototype = {
     "SessionStore:flush",
     "SessionStore:restoreHistory",
     "SessionStore:restoreTabContent",
   ],
 
   INNER_TO_OUTER_MESSAGES: [
     // Messages sent to browser.js
     "Browser:LoadURI",
-    "Link:SetIcon",
-    "Link:SetFailedIcon",
-    "Link:AddFeed",
-    "Link:AddSearch",
     // Messages sent to RemoteWebProgress.jsm
     "Content:LoadURIResult",
     "Content:LocationChange",
     "Content:ProgressChange",
     "Content:SecurityChange",
     "Content:StateChange",
     "Content:StatusChange",
     // Messages sent to remote-browser.xml
--- a/devtools/client/responsive.html/test/browser/browser.ini
+++ b/devtools/client/responsive.html/test/browser/browser.ini
@@ -3,18 +3,16 @@ tags = devtools
 subsuite = devtools
 # !e10s: RDM only works for remote tabs
 # Win: Bug 1319248
 skip-if = !e10s || os == "win"
 support-files =
   contextual_identity.html
   devices.json
   doc_page_state.html
-  favicon.html
-  favicon.ico
   geolocation.html
   head.js
   touch.html
   !/devtools/client/commandline/test/helpers.js
   !/devtools/client/inspector/test/shared-head.js
   !/devtools/client/shared/test/shared-head.js
   !/devtools/client/shared/test/shared-redux-head.js
   !/devtools/client/shared/test/telemetry-test-helpers.js
@@ -30,17 +28,16 @@ support-files =
 [browser_device_modal_error.js]
 [browser_device_modal_exit.js]
 [browser_device_modal_submit.js]
 [browser_device_pixel_ratio_change.js]
 [browser_device_width.js]
 [browser_exit_button.js]
 [browser_ext_messaging.js]
 tags = devtools webextensions
-[browser_favicon.js]
 [browser_frame_script_active.js]
 [browser_hide_container.js]
 [browser_menu_item_01.js]
 [browser_menu_item_02.js]
 [browser_mouse_resize.js]
 [browser_navigation.js]
 skip-if = true # Bug 1413765
 [browser_network_throttling.js]
deleted file mode 100644
--- a/devtools/client/responsive.html/test/browser/browser_favicon.js
+++ /dev/null
@@ -1,57 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
-   http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-// Test that favicons make it to the parent process.
-
-const TEST_URL = `${URL_ROOT}favicon.html`;
-
-function waitForLinkAvailable(browser) {
-  let resolve, reject;
-
-  const listener = {
-    onLinkIconAvailable(b, dataURI, iconURI) {
-      // Ignore icons for other browsers or empty icons.
-      if (browser !== b || !iconURI) {
-        return;
-      }
-
-      gBrowser.removeTabsProgressListener(listener);
-      resolve(iconURI);
-    }
-  };
-
-  const promise = new Promise((res, rej) => {
-    resolve = res;
-    reject = rej;
-
-    gBrowser.addTabsProgressListener(listener);
-  });
-
-  promise.cancel = () => {
-    gBrowser.removeTabsProgressListener(listener);
-
-    reject();
-  };
-
-  return promise;
-}
-
-add_task(async function() {
-  const tab = await addTab("about:blank");
-  const browser = tab.linkedBrowser;
-
-  await openRDM(tab);
-
-  const promise = waitForLinkAvailable(browser);
-  await load(browser, TEST_URL);
-  const iconURI = await promise;
-  is(iconURI, `${URL_ROOT}favicon.ico`, "Should have loaded the right icon.");
-  const icon = tab.getAttribute("image");
-  ok(icon.startsWith("data:"), "Should see the data icon on the tab.");
-
-  await closeRDM(tab);
-
-  await removeTab(tab);
-});
deleted file mode 100644
--- a/devtools/client/responsive.html/test/browser/favicon.html
+++ /dev/null
@@ -1,8 +0,0 @@
-<!doctype html>
-<html>
-  <head>
-    <title>Favicon Test</title>
-    <link rel="icon" href="favicon.ico">
-  </head>
-  <body/>
-</html>
deleted file mode 100644