Bug 1705784 [wpt PR 28549] - [GridNG] Apply alignment if possible within for the initial geometry., a=testonly
authorIan Kilpatrick <ikilpatrick@chromium.org>
Fri, 23 Apr 2021 10:22:24 +0000
changeset 577292 34c89e6bab413b6490f653705745efa00fff00dd
parent 577291 2716efda21d9f51b00d9df209cd8206ceea4a036
child 577293 240aaf537d6e8ffefd8ace5dde741a50c44abdeb
push id141827
push userwptsync@mozilla.com
push dateSat, 24 Apr 2021 02:11:12 +0000
treeherderautoland@3a7d9d49c316 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1705784, 28549, 1045599, 2698145, 873401
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1705784 [wpt PR 28549] - [GridNG] Apply alignment if possible within for the initial geometry., a=testonly Automatic update from web-platform-tests [GridNG] Apply alignment if possible within for the initial geometry. From: https://drafts.csswg.org/css-grid-1/#algo-overview "If both the grid container and all tracks have definite sizes, also apply align-content to find the final effective size of any gaps spanned by such items; otherwise ignore the effects of track alignment in this estimation." This implements the logic for above by adding a bit to the set if all our our tracks have fixed sizes, then using ComputeSetGeometry. The test for this sentence was incorrect, also fixed. Bug: 1045599 Change-Id: I6bd4ddf8c811b3ac175fe52ece6955eff5ed11bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698145 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#873401} -- wpt-commits: 34b73646e79843aee4ce4928e666d06d7b2773ac wpt-pr: 28549
testing/web-platform/tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
--- a/testing/web-platform/tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
+++ b/testing/web-platform/tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
@@ -30,12 +30,12 @@
 <script type="text/javascript">
   setup({ explicit_done: true });
 </script>
 
 <!-- Heuristic for estimating row-size for orthogonal items should
 also consider Content Alignment, so that grid container width is 40px.
 https://github.com/w3c/csswg-drafts/issues/2697 -->
 <body onload="document.fonts.ready.then(() => { checkLayout('.grid'); })">
-    <div class="grid justifyContentStart alignContentSpaceBetween" data-expected-width="80" data-expected-height="200">
+    <div class="grid justifyContentStart alignContentSpaceBetween" data-expected-width="40" data-expected-height="200">
         <div class="item" data-expected-width="40" data-expected-height="200">XXX XX X XX X XXX</div>
     </div>
 </body>