Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert
authorMats Palmgren <mats@mozilla.com>
Wed, 14 Aug 2019 14:35:56 +0000
changeset 487957 34bc9228d814dcd95beb0a673883f10263f17b75
parent 487956 57bcf2eea1098285fa30160590eaea97bf483692
child 487958 9651955468f878fce24919eb1a75238a7fc1049c
push id92552
push usermpalmgren@mozilla.com
push dateWed, 14 Aug 2019 15:17:47 +0000
treeherderautoland@34bc9228d814 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1569825
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D39810
devtools/shared/css/generated/properties-db.js
layout/inspector/tests/test_bug877690.html
servo/components/style/values/specified/box.rs
--- a/devtools/shared/css/generated/properties-db.js
+++ b/devtools/shared/css/generated/properties-db.js
@@ -5880,31 +5880,18 @@ exports.CSS_PROPERTIES = {
   },
   "display": {
     "isInherited": false,
     "subproperties": [
       "display"
     ],
     "supports": [],
     "values": [
-      "-moz-box",
-      "-moz-deck",
-      "-moz-grid",
-      "-moz-grid-group",
-      "-moz-grid-line",
-      "-moz-groupbox",
-      "-moz-inline-box",
-      "-moz-inline-grid",
-      "-moz-inline-stack",
-      "-moz-popup",
-      "-moz-stack",
       "-webkit-box",
-      "-webkit-flex",
       "-webkit-inline-box",
-      "-webkit-inline-flex",
       "block",
       "contents",
       "flex",
       "flow-root",
       "grid",
       "inherit",
       "initial",
       "inline",
--- a/layout/inspector/tests/test_bug877690.html
+++ b/layout/inspector/tests/test_bug877690.html
@@ -84,21 +84,18 @@ function do_test() {
   var expected = [ "initial", "inherit", "unset", "revert" ];
   ok(testValues(values, expected), "property padding-bottom's values.");
 
   // test proprety
   var prop = "display";
   var values = InspectorUtils.getCSSValuesForProperty(prop);
   var expected = [ "initial", "inherit", "unset", "revert", "none", "inline", "block", "inline-block", "list-item",
       "table", "inline-table", "table-row-group", "table-header-group", "table-footer-group", "table-row",
-      "table-column-group", "table-column", "table-cell", "table-caption", "-moz-box", "-moz-inline-box",
-      "-moz-grid", "-moz-inline-grid", "-moz-grid-group", "-moz-grid-line", "-moz-stack", "-moz-inline-stack",
-      "-moz-deck", "-moz-popup", "-moz-groupbox",
+      "table-column-group", "table-column", "table-cell", "table-caption",
       "flex", "inline-flex", "-webkit-box", "-webkit-inline-box",
-      "-webkit-flex", "-webkit-inline-flex",
       "grid", "inline-grid",
       "ruby", "ruby-base", "ruby-base-container", "ruby-text", "ruby-text-container",
       "contents", "flow-root" ];
   ok(testValues(values, expected), "property display's values.");
 
   // test property
   var prop = "float";
   var values = InspectorUtils.getCSSValuesForProperty(prop);
--- a/servo/components/style/values/specified/box.rs
+++ b/servo/components/style/values/specified/box.rs
@@ -743,29 +743,16 @@ impl SpecifiedValueInfo for Display {
           "table-column",
           "table-column-group",
           "table-footer-group",
           "table-header-group",
           "table-row",
           "table-row-group",
           "-webkit-box",
           "-webkit-inline-box",
-          "-webkit-flex",
-          "-webkit-inline-flex",
-          "-moz-box",
-          "-moz-inline-box",
-          "-moz-grid",
-          "-moz-inline-grid",
-          "-moz-grid-group",
-          "-moz-grid-line",
-          "-moz-stack",
-          "-moz-inline-stack",
-          "-moz-deck",
-          "-moz-popup",
-          "-moz-groupbox",
       ]);
     }
 }
 
 /// A specified value for the `vertical-align` property.
 pub type VerticalAlign = GenericVerticalAlign<LengthPercentage>;
 
 impl Parse for VerticalAlign {