Bug 1646916 - [DoH rollout] Add missing enums to preferences API input params. r=mixedpuppy
authorNihanth Subramanya <nhnt11@gmail.com>
Fri, 19 Jun 2020 06:13:57 +0000
changeset 536464 341563fe54635619fd28b8928d5876dbcc5a21e6
parent 536463 a7234b23fcd3a015fba992bc9f233a8010e44033
child 536465 bc99994775ba81dd955d5e1ced2c3a69efb8e599
push id119468
push usernhnt11@gmail.com
push dateFri, 19 Jun 2020 06:21:29 +0000
treeherderautoland@341563fe5463 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy
bugs1646916
milestone79.0a1
first release with
nightly linux32
341563fe5463 / 79.0a1 / 20200619092144 / files
nightly linux64
341563fe5463 / 79.0a1 / 20200619092144 / files
nightly mac
341563fe5463 / 79.0a1 / 20200619092144 / files
nightly win32
341563fe5463 / 79.0a1 / 20200619092144 / files
nightly win64
341563fe5463 / 79.0a1 / 20200619092144 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1646916 - [DoH rollout] Add missing enums to preferences API input params. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D80334
browser/extensions/doh-rollout/experiments/preferences/schema.json
--- a/browser/extensions/doh-rollout/experiments/preferences/schema.json
+++ b/browser/extensions/doh-rollout/experiments/preferences/schema.json
@@ -19,17 +19,18 @@
     "functions": [
       {
         "name": "getIntPref",
         "type": "function",
         "description": "Get the value of a integer preference",
         "parameters": [
           {
             "type": "string",
-            "name": "name"
+            "name": "name",
+            "enum": ["doh-rollout.previous.trr.mode"]
           },
           {
             "type": "integer",
             "name": "defaultValue"
           }
         ],
         "async": true
       },
@@ -51,49 +52,72 @@
       },
       {
         "name": "getBoolPref",
         "type": "function",
         "description": "Get the value of a boolean preference",
         "parameters": [
           {
             "type": "string",
-            "name": "name"
+            "name": "name",
+            "enum": [
+              "doh-rollout.enabled",
+              "doh-rollout.self-enabled",
+              "doh-rollout.doorhanger-shown",
+              "doh-rollout.disable-heuristics",
+              "doh-rollout.skipHeuristicsCheck",
+              "doh-rollout.doneFirstRun",
+              "doh-rollout.balrog-migration-done",
+              "doh-rollout.debug",
+              "doh-rollout.provider-steering.enabled",
+              "security.enterprise_roots.enabled"
+            ]
           },
           {
             "type": "boolean",
             "name": "defaultValue"
           }
         ],
         "async": true
       },
       {
         "name": "setBoolPref",
         "type": "function",
         "description": "Sets the value of a boolean preference",
         "parameters": [
           {
             "type": "string",
-            "enum": ["doh-rollout.doorhanger-shown", "doh-rollout.self-enabled", "doh-rollout.disable-heuristics", "doh-rollout.doneFirstRun", "doh-rollout.skipHeuristicsCheck", "doh-rollout.balrog-migration-done"]
+            "enum": [
+              "doh-rollout.doorhanger-shown",
+              "doh-rollout.self-enabled",
+              "doh-rollout.disable-heuristics",
+              "doh-rollout.doneFirstRun",
+              "doh-rollout.skipHeuristicsCheck",
+              "doh-rollout.balrog-migration-done"
+            ]
           },
           {
             "type": "boolean",
             "name": "defaultValue"
           }
         ],
         "async": true
       },
       {
         "name": "getCharPref",
         "type": "function",
         "description": "Gets the value of a string preference",
         "parameters": [
           {
             "type": "string",
-            "enum": ["doh-rollout.doorhanger-decision", "doh-rollout.heuristics.mockValues", "doh-rollout.provider-steering.provider-list"]
+            "enum": [
+              "doh-rollout.doorhanger-decision",
+              "doh-rollout.heuristics.mockValues",
+              "doh-rollout.provider-steering.provider-list"
+            ]
           },
           {
             "type": "string",
             "name": "defaultValue"
           }
         ],
         "async": true
       },
@@ -115,29 +139,35 @@
       },
       {
         "name": "clearUserPref",
         "type": "function",
         "description": "Resets value of prefence back to default",
         "parameters": [
           {
             "type": "string",
-            "enum": ["doh-rollout.self-enabled", "doh-rollout.mode", "network.trr.mode", "doh-rollout.previous.trr.mode"]
+            "enum": [
+              "doh-rollout.self-enabled",
+              "doh-rollout.mode",
+              "network.trr.mode",
+              "doh-rollout.previous.trr.mode"
+            ]
           }
         ],
         "async": true
       },
       {
         "name": "prefHasUserValue",
         "type": "function",
         "description": "Check if the user has set a value of a preference",
         "parameters": [
           {
             "type": "string",
-            "name": "name"
+            "name": "name",
+            "enum": ["network.trr.mode", "network.trr.uri"]
           }
         ],
         "async": true
       },
       {
         "name": "migrateNextDNSEndpoint",
         "type": "function",
         "description": "Migrates any occurrances of old NextDNS endpoint URL in pref values to the new endpoint.",