Bug 1594842 - Move gecko-profiler-interface.js out of the server and into shared; r=julienw
authorGreg Tatum <gtatum@mozilla.com>
Tue, 12 Nov 2019 19:07:03 +0000
changeset 501643 3391d89f2d1868f94c7a0c699aba9a324dd4eb26
parent 501642 76cd5919691eeab197d66c9e70944003a6c0c207
child 501644 6c661bae8d399e9975d8da2500057ca5c16398d3
push id100339
push usergtatum@mozilla.com
push dateTue, 12 Nov 2019 20:02:06 +0000
treeherderautoland@cb7761bc9859 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjulienw
bugs1594842
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594842 - Move gecko-profiler-interface.js out of the server and into shared; r=julienw It's being used in the client and server, and so is a shared file. Differential Revision: https://phabricator.services.mozilla.com/D52247
devtools/client/performance-new/popup/initializer.js
devtools/server/actors/perf.js
devtools/server/moz.build
devtools/server/performance-new/gecko-profiler-interface.js
devtools/server/performance-new/moz.build
devtools/shared/moz.build
devtools/shared/performance-new/gecko-profiler-interface.js
devtools/shared/performance-new/moz.build
--- a/devtools/client/performance-new/popup/initializer.js
+++ b/devtools/client/performance-new/popup/initializer.js
@@ -59,17 +59,17 @@ const Perf = require("devtools/client/pe
 const ReactDOM = require("devtools/client/shared/vendor/react-dom");
 const React = require("devtools/client/shared/vendor/react");
 const createStore = require("devtools/client/shared/redux/create-store");
 const reducers = require("devtools/client/performance-new/store/reducers");
 const actions = require("devtools/client/performance-new/store/actions");
 const { Provider } = require("devtools/client/shared/vendor/react-redux");
 const {
   ActorReadyGeckoProfilerInterface,
-} = require("devtools/server/performance-new/gecko-profiler-interface");
+} = require("devtools/shared/performance-new/gecko-profiler-interface");
 
 const { LightweightThemeManager } = ChromeUtils.import(
   "resource://gre/modules/LightweightThemeManager.jsm"
 );
 
 /* Force one of our two themes depending on what theme the browser is
  * currently using. This might be different from the selected theme in
  * the devtools panel. By forcing a theme here, we're unaffected by
--- a/devtools/server/actors/perf.js
+++ b/devtools/server/actors/perf.js
@@ -4,17 +4,17 @@
 "use strict";
 
 const protocol = require("devtools/shared/protocol");
 const { ActorClassWithSpec, Actor } = protocol;
 const { actorBridgeWithSpec } = require("devtools/server/actors/common");
 const { perfSpec } = require("devtools/shared/specs/perf");
 const {
   ActorReadyGeckoProfilerInterface,
-} = require("devtools/server/performance-new/gecko-profiler-interface");
+} = require("devtools/shared/performance-new/gecko-profiler-interface");
 
 /**
  * Pass on the events from the bridge to the actor.
  * @param {Object} actor The perf actor
  * @param {Array<string>} names The event names
  */
 function _bridgeEvents(actor, names) {
   for (const name of names) {
--- a/devtools/server/moz.build
+++ b/devtools/server/moz.build
@@ -5,17 +5,16 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 include('../templates.mozbuild')
 
 DIRS += [
     'actors',
     'connectors',
     'performance',
-    'performance-new',
     'socket',
     'startup',
 ]
 
 if CONFIG['MOZ_BUILD_APP'] != 'mobile/android':
     BROWSER_CHROME_MANIFESTS += ['tests/browser/browser.ini']
 
 MOCHITEST_CHROME_MANIFESTS += ['tests/mochitest/chrome.ini']
--- a/devtools/shared/moz.build
+++ b/devtools/shared/moz.build
@@ -15,16 +15,17 @@ DIRS += [
     'fronts',
     'heapsnapshot',
     'inspector',
     'jsbeautify',
     'layout',
     'locales',
     'node-properties',
     'performance',
+    'performance-new',
     'platform',
     'protocol',
     'qrcode',
     'resources',
     'screenshot',
     'security',
     'sprintfjs',
     'specs',
rename from devtools/server/performance-new/gecko-profiler-interface.js
rename to devtools/shared/performance-new/gecko-profiler-interface.js
rename from devtools/server/performance-new/moz.build
rename to devtools/shared/performance-new/moz.build