Bug 1598455 - Enable User Initiated Picture-in-Picture for macOS and Linux GTK by default. r=mstriemer
authorMike Conley <mconley@mozilla.com>
Thu, 21 Nov 2019 21:56:47 +0000
changeset 503358 3020a835765641effd16d949ebed09e15740210a
parent 503357 f433ef4311a87f50fbfb36bfb1ddf06af33d9f99
child 503359 e2cdd6a01a70e979c24447436f56a3b2b9e39fa8
push id101287
push usermconley@mozilla.com
push dateFri, 22 Nov 2019 12:19:27 +0000
treeherderautoland@3020a8357656 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstriemer
bugs1598455
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1598455 - Enable User Initiated Picture-in-Picture for macOS and Linux GTK by default. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D54188
browser/app/profile/firefox.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1502,29 +1502,18 @@ pref("media.autoplay.default", 1); // 0=
 
 #ifdef NIGHTLY_BUILD
   // Block WebAudio from playing automatically.
   pref("media.autoplay.block-webaudio", true);
 #else
   pref("media.autoplay.block-webaudio", false);
 #endif
 
-// Picture-in-Picture is currently enabled by default on Windows.
-#if defined(XP_WIN)
-  pref("media.videocontrols.picture-in-picture.enabled", true);
-  pref("media.videocontrols.picture-in-picture.video-toggle.enabled", true);
-#endif
-
-// Picture-in-Picture is currently enabled on Nightly for macOS and Linux GTK.
-#if defined(XP_MACOSX) || defined(MOZ_WIDGET_GTK)
-  #if defined(NIGHTLY_BUILD)
-    pref("media.videocontrols.picture-in-picture.enabled", true);
-    pref("media.videocontrols.picture-in-picture.video-toggle.enabled", true);
-  #endif
-#endif
+pref("media.videocontrols.picture-in-picture.enabled", true);
+pref("media.videocontrols.picture-in-picture.video-toggle.enabled", true);
 
 // Show the audio toggle for Picture-in-Picture.
 pref("media.videocontrols.picture-in-picture.audio-toggle.enabled", false);
 
 pref("browser.translation.detectLanguage", false);
 pref("browser.translation.neverForLanguages", "");
 // Show the translation UI bits, like the info bar, notification icon and preferences.
 pref("browser.translation.ui.show", false);