Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo
☠☠ backed out by 917d14c79f2b ☠ ☠
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 28 Mar 2017 16:48:20 +0100
changeset 351134 2f0db92fbe1b9106b1dd6fbf236f612f4283ec7b
parent 351133 142552196615cc1306d958ea29c59f14cd218126
child 351135 12afeda05d4759b67b9dc82b1f1fee7957ce77c4
push id40057
push useratolfsen@mozilla.com
push dateTue, 04 Apr 2017 13:09:12 +0000
treeherderautoland@12afeda05d47 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswhimboo
bugs1350887
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo Errors thrown are printed to console and there is no point in having a custom catch to print it. This also makes it possible to start Marionette programmatically without worrying about disappearing errors. MozReview-Commit-ID: GGhyCyYqJg
testing/marionette/components/marionette.js
--- a/testing/marionette/components/marionette.js
+++ b/testing/marionette/components/marionette.js
@@ -292,19 +292,16 @@ MarionetteComponent.prototype.init = fun
   }
 
   let s;
   try {
     Cu.import("chrome://marionette/content/server.js");
     s = new server.TCPListener(prefs.port, prefs.forceLocal);
     s.start();
     this.logger.info(`Listening on port ${s.port}`);
-  } catch (e) {
-    this.logger.error(`Error on starting server: ${e}`);
-    dump(`${e.toString()}\n${e.stack}\n`);
   } finally {
     if (s) {
       this.server = s;
       this.running = true;
     }
   }
 };