Bug 1703889 - Move disabled action fill-opacity rule into non Proton CSS rules. r=mak
authorLuca Greco <lgreco@mozilla.com>
Mon, 12 Apr 2021 12:07:00 +0000
changeset 575456 2e13cdc47fb91949c48627656604bbce3b632847
parent 575455 f54c679ded81eeebe05fa63d48be29a556118ac5
child 575457 df04c1a4ef97cdbdc33421ee9d71fe21a0ba210d
push id140727
push userluca.greco@alcacoop.it
push dateMon, 12 Apr 2021 13:44:50 +0000
treeherderautoland@2e13cdc47fb9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak
bugs1703889
milestone89.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1703889 - Move disabled action fill-opacity rule into non Proton CSS rules. r=mak In the Proton UI the disabled extension pageActions are not available in both the urlbar and the urlbar overflow menu, and non or the builtin actions seems to be visible when disabled in Proton. And so this particular rule isn't needed in Proton and can be moved into the group of stylesheet rules restricted to the non-Proton UI. Differential Revision: https://phabricator.services.mozilla.com/D111602
browser/themes/shared/urlbar-searchbar.inc.css
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -623,21 +623,21 @@
   height: calc(var(--urlbar-min-height) - 2px);
   margin-inline: 0;
 }
 
 .urlbar-icon,
 .urlbar-icon-wrapper {
   border-radius: 0;
 }
-} /*** END !proton ***/
 
 .urlbar-page-action[disabled] {
   fill-opacity: 0.3;
 }
+} /*** END !proton ***/
 
 :not(.urlbar-icon-wrapper) > .urlbar-icon:not([disabled]):hover,
 .urlbar-icon-wrapper:not([disabled]):hover {
   background-color: hsla(0,0%,70%,.2);
 }
 
 :not(.urlbar-icon-wrapper) > .urlbar-icon:not([disabled])[open],
 :not(.urlbar-icon-wrapper) > .urlbar-icon:not([disabled]):hover:active,