Backed out changeset c6bc4817cea2 (bug 1619837) for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE
authorshindli <shindli@mozilla.com>
Wed, 11 Mar 2020 09:57:06 +0200
changeset 518075 2aadc604b542e70f7aeac259f11d1c6cea5a4a0a
parent 518074 e9deb7829d0b4a47fcccf766de874a42ca8898bc
child 518076 c76a8a4656fda1aa5e5f73fb42fc75f6205ceea3
push id109772
push usershindli@mozilla.com
push dateWed, 11 Mar 2020 07:58:09 +0000
treeherderautoland@2aadc604b542 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1619837
milestone76.0a1
backs outc6bc4817cea20b9ab1d970859bbdde889914f2cf
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset c6bc4817cea2 (bug 1619837) for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE
testing/mozbase/mozrunner/mozrunner/utils.py
--- a/testing/mozbase/mozrunner/mozrunner/utils.py
+++ b/testing/mozbase/mozrunner/mozrunner/utils.py
@@ -254,20 +254,32 @@ def get_stack_fixer_function(utilityPath
         # This method is preferred for Tinderbox builds, since native
         # symbols may have been stripped.
         stack_fixer_module = import_stack_fixer_module(
             'fix_stack_using_bpsyms')
 
         def stack_fixer_function(line):
             return stack_fixer_module.fixSymbols(line, symbolsPath)
 
-    elif mozinfo.isLinux or mozinfo.isMac or mozinfo.isWin:
-        # Run each line through fix_stacks.py. This method is preferred for
-        # developer machines, so we don't have to run "mach buildsymbols".
-        stack_fixer_module = import_stack_fixer_module('fix_stacks')
+    elif mozinfo.isMac:
+        # Run each line through fix_macosx_stack.py (uses atos).
+        # This method is preferred for developer machines, so we don't
+        # have to run "make buildsymbols".
+        stack_fixer_module = import_stack_fixer_module(
+            'fix_macosx_stack')
+
+        def stack_fixer_function(line):
+            return stack_fixer_module.fixSymbols(line)
+
+    elif mozinfo.isLinux:
+        # Run each line through fix_linux_stack.py (uses addr2line).
+        # This method is preferred for developer machines, so we don't
+        # have to run "make buildsymbols".
+        stack_fixer_module = import_stack_fixer_module(
+            'fix_linux_stack')
 
         def stack_fixer_function(line):
             return stack_fixer_module.fixSymbols(line)
 
     else:
         return None
 
     return stack_fixer_function