Bug 1399180 - select devtools tab on mousedown rather than on click;r=gl
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 12 Sep 2017 18:35:38 +0200
changeset 380374 2a131a0c2d11563c36a513599a138c0e6a2ab277
parent 380373 b8cb090f952bc1e9837222586d205c00fd53a78f
child 380375 4ab54f3ebbc58048a6a32929782657e688f6faa4
push id51039
push userjdescottes@mozilla.com
push dateWed, 13 Sep 2017 01:19:03 +0000
treeherderautoland@2a131a0c2d11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1399180
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1399180 - select devtools tab on mousedown rather than on click;r=gl MozReview-Commit-ID: 8m3pS4ZRJ73
devtools/client/framework/components/toolbox-tab.js
--- a/devtools/client/framework/components/toolbox-tab.js
+++ b/devtools/client/framework/components/toolbox-tab.js
@@ -48,17 +48,17 @@ module.exports = createClass({
       {
         className,
         id: `toolbox-tab-${id}`,
         "data-id": id,
         title: tooltip,
         type: "button",
         tabIndex: focusedButton === id ? "0" : "-1",
         onFocus: () => focusButton(id),
-        onClick: () => selectTool(id),
+        onMouseDown: () => selectTool(id),
       },
       span(
         {
           className: "devtools-tab-line"
         }
       ),
       ...this.renderIcon(panelDefinition, isHighlighted),
       iconOnly ?