autoland: changeset 545125:25473dfe87715a98b1f35f5bb05e59c14429628b

author	Andrew McCreight <continuation@gmail.com>
	Tue, 18 Aug 2020 13:15:41 +0000
changeset 545125	25473dfe87715a98b1f35f5bb05e59c14429628b
parent 545124	5007c1c9c60c0b0d93ad11eedc89e629c4fab91c
child 545126	b528e9b6bab0bc66f79e9200bdbfe449573516e0
push id	124397
push user	amccreight@mozilla.com
push date	Tue, 18 Aug 2020 15:50:08 +0000
treeherder	autoland@25473dfe8771 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	froydnj
bugs	1659567
milestone	81.0a1
first release with	nightly linux32 069bb8bd2356 / 81.0a1 / 20200818214031 / files nightly linux64 069bb8bd2356 / 81.0a1 / 20200818214031 / files nightly mac 069bb8bd2356 / 81.0a1 / 20200818214031 / files nightly win32 069bb8bd2356 / 81.0a1 / 20200818214031 / files nightly win64 069bb8bd2356 / 81.0a1 / 20200818214031 / files
last release without	nightly linux32 483ef87aa6e8 / 81.0a1 / 20200818092452 / files nightly linux64 483ef87aa6e8 / 81.0a1 / 20200818092452 / files nightly mac 483ef87aa6e8 / 81.0a1 / 20200818092452 / files nightly win32 483ef87aa6e8 / 81.0a1 / 20200818092452 / files nightly win64 483ef87aa6e8 / 81.0a1 / 20200818092452 / files

Bug 1659567 - Add a memory reporter for gAccessCounts. r=froydnj This table is only in debug builds, but it takes up about 100kb, so it sticks out in DMD reports taken in debug builds. Differential Revision: https://phabricator.services.mozilla.com/D87347

modules/libpref/Preferences.cpp

file | annotate | diff | comparison | revisions

--- a/modules/libpref/Preferences.cpp
+++ b/modules/libpref/Preferences.cpp
@@ -3131,16 +3131,22 @@ PreferenceServiceReporter::CollectReport
   for (CallbackNode* node = gFirstCallback; node; node = node->Next()) {
     node->AddSizeOfIncludingThis(mallocSizeOf, sizes);
   }
 
   if (gSharedMap) {
     sizes.mMisc += mallocSizeOf(gSharedMap);
   }
 
+#ifdef ACCESS_COUNTS
+  if (gAccessCounts) {
+    sizes.mMisc += gAccessCounts->ShallowSizeOfIncludingThis(mallocSizeOf);
+  }
+#endif
+
   MOZ_COLLECT_REPORT("explicit/preferences/hash-table", KIND_HEAP, UNITS_BYTES,
                      sizes.mHashTable, "Memory used by libpref's hash table.");
 
   MOZ_COLLECT_REPORT("explicit/preferences/pref-values", KIND_HEAP, UNITS_BYTES,
                      sizes.mPrefValues,
                      "Memory used by PrefValues hanging off the hash table.");
 
   MOZ_COLLECT_REPORT("explicit/preferences/string-values", KIND_HEAP,