Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel, r=Gijs
authorFischer.json <fischer.json@gmail.com>
Wed, 16 Aug 2017 15:22:24 +0800
changeset 375240 23a7aa3e23c560acc6a10f0e492e694ab24cc932
parent 375239 49e99ad05e7690f353f00858a1433cb9d9de82c4
child 375241 9fb2a131d67ff1e2b9eed9a5c38c71862ccab8db
push id48989
push userryanvm@gmail.com
push dateThu, 17 Aug 2017 03:07:58 +0000
treeherderautoland@23a7aa3e23c5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1390767
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel, r=Gijs MozReview-Commit-ID: LYVc3kRPEfZ
browser/components/uitour/UITour.jsm
--- a/browser/components/uitour/UITour.jsm
+++ b/browser/components/uitour/UITour.jsm
@@ -1144,17 +1144,17 @@ this.UITour = {
       highlighter.parentElement.setAttribute("targetName", aTarget.targetName);
       highlighter.parentElement.hidden = false;
 
       let highlightAnchor = aAnchorEl;
       let targetRect = highlightAnchor.getBoundingClientRect();
       let highlightHeight = targetRect.height;
       let highlightWidth = targetRect.width;
 
-      if (this.targetIsInAppMenu(aTarget)) {
+      if (this.targetIsInAppMenu(aTarget) || this.targetIsInPageActionPanel(aTarget)) {
         highlighter.classList.remove("rounded-highlight");
       } else {
         highlighter.classList.add("rounded-highlight");
       }
       if (highlightAnchor.classList.contains("toolbarbutton-1") &&
           highlightAnchor.getAttribute("cui-areatype") === "toolbar" &&
           highlightAnchor.getAttribute("overflowedItem") !== "true") {
         // A toolbar button in navbar has its clickable area an