Fix a couple of comments.
authorBrendan Eich <brendan@mozilla.org>
Tue, 29 Jul 2008 10:53:58 -0700
changeset 17876 21de271f5a7b21f0f37df367fef6212b7af99b51
parent 17872 624a5f42008b63d7bf10f5a791eb093bbba3580d
child 17877 df9c6c6a62bfcf1271a80ce10f16259d75a20377
push id1452
push usershaver@mozilla.com
push dateFri, 22 Aug 2008 00:08:22 +0000
treeherderautoland@d13bb0868596 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9.1a1pre
Fix a couple of comments.
js/src/jstracer.cpp
--- a/js/src/jstracer.cpp
+++ b/js/src/jstracer.cpp
@@ -3550,17 +3550,19 @@ bool TraceRecorder::record_JSOP_STARTXML
 
 bool TraceRecorder::record_JSOP_CALLELEM()
 {
     return false;
 }
 
 bool TraceRecorder::record_JSOP_STOP()
 {
-    // Update this when we implement POPV.
+    // We know falling off the end of a function returns undefined, and we do
+    // not support script rval (eval, API users who want the result of the last
+    // expression-statement, debugger API calls).
     rval_ins = lir->insImm(JSVAL_TO_BOOLEAN(JSVAL_VOID));
     clearFrameSlotsFromCache();
     return true;
 }
 
 bool TraceRecorder::record_JSOP_GETXPROP()
 {
     jsval& l = stackval(-1);
@@ -3758,17 +3760,18 @@ bool TraceRecorder::record_JSOP_INT32()
 bool TraceRecorder::record_JSOP_LENGTH()
 {
     jsval& l = stackval(-1);
     if (JSVAL_IS_PRIMITIVE(l)) {
         if (!JSVAL_IS_STRING(l))
             ABORT_TRACE("non-string primitives unsupported");
         LIns* str_ins = get(&l);
         LIns* len_ins = lir->insLoadi(str_ins, offsetof(JSString, length));
-        // We only support flat strings
+
+        // We support only flat strings at present.
         guard(true, addName(lir->ins_eq0(lir->ins2(LIR_and, len_ins,
                                                    INS_CONST(JSSTRFLAG_DEPENDENT))),
                             "guard(flat-string)"));
         set(&l, lir->ins1(LIR_i2f, 
                           lir->ins2(LIR_and, len_ins, INS_CONST(JSSTRING_LENGTH_MASK))));
         return true;
     }