Bug 835796 - Negative value in about:memory storage/sqlite/other due to double-counting of shared-cache connections. r=asuth
authorMarco Bonardo <mbonardo@mozilla.com>
Thu, 03 Nov 2016 23:14:35 +0100
changeset 321000 1fa12824f3d8953b20698f2a0acf24d94a205f2b
parent 320999 4c050d33b8424ef92cf6cfe6befb135dd18b80be
child 321001 991a332ae4e3379110f294148e09754cc5bb8cc9
push id33915
push usermak77@bonardo.net
push dateFri, 04 Nov 2016 21:22:44 +0000
treeherderautoland@1fa12824f3d8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs835796
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 835796 - Negative value in about:memory storage/sqlite/other due to double-counting of shared-cache connections. r=asuth MozReview-Commit-ID: 2rO5sApv6rn
storage/mozStorageService.cpp
--- a/storage/mozStorageService.cpp
+++ b/storage/mozStorageService.cpp
@@ -151,17 +151,17 @@ Service::CollectReports(nsIHandleReportC
                  NS_LITERAL_CSTRING("stmt"), stmtDesc,
                  SQLITE_DBSTATUS_STMT_USED, &totalConnSize);
 
       NS_NAMED_LITERAL_CSTRING(cacheDesc,
         "Memory (approximate) used by all pager caches used by connections "
         "to this database.");
       ReportConn(aHandleReport, aData, conn, pathHead,
                  NS_LITERAL_CSTRING("cache"), cacheDesc,
-                 SQLITE_DBSTATUS_CACHE_USED, &totalConnSize);
+                 SQLITE_DBSTATUS_CACHE_USED_SHARED, &totalConnSize);
 
       NS_NAMED_LITERAL_CSTRING(schemaDesc,
         "Memory (approximate) used to store the schema for all databases "
         "associated with connections to this database.");
       ReportConn(aHandleReport, aData, conn, pathHead,
                  NS_LITERAL_CSTRING("schema"), schemaDesc,
                  SQLITE_DBSTATUS_SCHEMA_USED, &totalConnSize);
     }