Backed out changeset 66a484400799 (bug 1718934) for mochitest failures on test_value_computation.html . CLOSED TREE
authorNarcis Beleuzu <nbeleuzu@mozilla.com>
Thu, 08 Jul 2021 00:37:51 +0300
changeset 585050 1f558a68ac6ed78b9c4a1b36445d6e6013a06ca4
parent 585049 5b1e3a5ccee5027efefadfc29929cac0b1ffe165
child 585053 7e3ec6212b9db914e80344d1645b2c6b83f1e358
push id145970
push usernbeleuzu@mozilla.com
push dateWed, 07 Jul 2021 21:38:16 +0000
treeherderautoland@1f558a68ac6e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1718934
milestone91.0a1
backs out66a4844007997a6d169829582df1bcbdbcefd346
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 66a484400799 (bug 1718934) for mochitest failures on test_value_computation.html . CLOSED TREE
layout/style/test/property_database.js
servo/components/style/values/specified/color.rs
widget/nsXPLookAndFeel.cpp
--- a/layout/style/test/property_database.js
+++ b/layout/style/test/property_database.js
@@ -5206,18 +5206,16 @@ var gCSSProperties = {
       "highlight",
       "highlighttext",
       "graytext",
       /* Preserve previously available specially prefixed colors */
       "-moz-activehyperlinktext",
       "-moz-default-background-color",
       "-moz-hyperlinktext",
       "-moz-visitedhyperlinktext",
-      /* Needed for compat */
-      "-webkit-focus-ring-color",
     ],
     invalid_values: [
       "#f",
       "#ff",
       "#fffff",
       "#fffffff",
       "#fffffffff",
       "rgb(100%, 0, 100%)",
--- a/servo/components/style/values/specified/color.rs
+++ b/servo/components/style/values/specified/color.rs
@@ -335,20 +335,16 @@ pub enum SystemColor {
     MozMacMenupopup,
     MozMacMenuitem,
     MozMacActiveMenuitem,
     MozMacSourceList,
     MozMacSourceListSelection,
     MozMacActiveSourceListSelection,
     MozMacTooltip,
 
-    /// Parsed for compat, effectively black (not implemented in any platform).
-    /// See bug 1718934.
-    WebkitFocusRingColor,
-
     /// Theme accent color.
     #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
     MozAccentColor,
 
     /// Foreground for the accent color.
     #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
     MozAccentColorForeground,
 
--- a/widget/nsXPLookAndFeel.cpp
+++ b/widget/nsXPLookAndFeel.cpp
@@ -294,17 +294,16 @@ static const char sColorPrefs[][41] = {
     "ui.-moz-mac-vibrant-titlebar-dark",
     "ui.-moz-mac-menupopup",
     "ui.-moz-mac-menuitem",
     "ui.-moz-mac-active-menuitem",
     "ui.-moz-mac-source-list",
     "ui.-moz-mac-source-list-selection",
     "ui.-moz-mac-active-source-list-selection",
     "ui.-moz-mac-tooltip",
-    "ui.-webkit-focus-ring-color",
     "ui.-moz-accent-color",
     "ui.-moz-accent-color-foreground",
     "ui.-moz-win-mediatext",
     "ui.-moz-win-communicationstext",
     "ui.-moz-nativehyperlinktext",
     "ui.-moz-hyperlinktext",
     "ui.-moz-activehyperlinktext",
     "ui.-moz-visitedhyperlinktext",