Bug 1543696 - Don't set extensions.legacy.enabled on beta in browser_ext_themes_experiment.js. r=kmag
☠☠ backed out by 5f989e2d7359 ☠ ☠
authorTim Nguyen <ntim.bugs@gmail.com>
Sat, 13 Apr 2019 10:07:27 +0000
changeset 469398 1ee98a3cd8fb212340a25bdc3f0764dfca08daa0
parent 469397 7dad55e9bd2bd60ea5462c2cfa1281a82aa0a4b6
child 469399 5f989e2d735902a87a300c8791050926ce2993d3
push id83126
push userntim.bugs@gmail.com
push dateSat, 13 Apr 2019 10:08:08 +0000
treeherderautoland@1ee98a3cd8fb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1543696
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1543696 - Don't set extensions.legacy.enabled on beta in browser_ext_themes_experiment.js. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D27153
toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
toolkit/mozapps/extensions/content/aboutaddons.css
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
@@ -1,16 +1,18 @@
 "use strict";
 
 // This test checks whether the theme experiments work
 
 add_task(async function setup() {
-  await SpecialPowers.pushPrefEnv({
-    set: [["extensions.legacy.enabled", true]],
-  });
+  if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
+    await SpecialPowers.pushPrefEnv({
+      set: [["extensions.legacy.enabled", true]],
+    });
+  }
 });
 
 add_task(async function test_experiment_static_theme() {
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         colors: {
           some_color_property: "#ff00ff",
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
@@ -68,17 +68,19 @@ add_task(async function test_dynamic_the
       `Unrecognized theme property found: ${property}.such_property`
     );
   }
 
   await extension.unload();
 });
 
 add_task(async function test_experiment() {
-  Services.prefs.setBoolPref("extensions.legacy.enabled", true);
+  await SpecialPowers.pushPrefEnv({
+    set: [["extensions.legacy.enabled", true]],
+  });
 
   info("Testing that experiments are handled correctly when legacy pref is enabled");
 
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
@@ -102,17 +104,17 @@ add_task(async function test_experiment(
       extension.startup,
       "Unrecognized theme property found: properties.unknown_property"
     );
   }
   await extension.unload();
 
   info("Testing that experiments are handled correctly when legacy pref is disabled");
 
-  Services.prefs.setBoolPref("extensions.legacy.enabled", false);
+  await SpecialPowers.popPrefEnv();
 
   extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
         },
       },
--- a/toolkit/mozapps/extensions/content/aboutaddons.css
+++ b/toolkit/mozapps/extensions/content/aboutaddons.css
@@ -63,17 +63,16 @@ addon-list .addon.card {
 
 .card-actions {
   flex-shrink: 0;
 }
 
 .addon-name {
   font-size: 16px;
   font-weight: 600;
-  color: var(--grey-90);
   line-height: 22px;
   /* Subtract the top line-height so the text and icon align at the top. */
   margin-top: -3px;
 }
 
 .addon-description {
   font-size: 14px;
   line-height: 20px;
@@ -189,16 +188,18 @@ addon-details {
 }
 
 button[action="more-options"] {
   min-width: auto;
   min-height: auto;
   width: 24px;
   height: 24px;
   margin: 0;
+  -moz-context-properties: fill;
+  fill: currentColor;
   background: url("chrome://global/skin/icons/more.svg") no-repeat center center;
 }
 
 panel-item[action="remove"] {
   -moz-context-properties: fill;
   fill: currentColor;
   --icon: url("chrome://global/skin/icons/delete.svg");
 }