Bug 1325801 - Fix intermittent failure staging cppunittests. r=mshal
authorChris Manchester <cmanchester@mozilla.com>
Fri, 06 Jan 2017 15:41:22 -0800
changeset 328351 1d126c201b0f8acfc55a2fc965cc87e786740cf8
parent 328350 3644b91c1e1c491e25605d5475e501cdbe360d48
child 328352 a8faa9781c5b4bc517af91de0a1da2753515d450
push id35757
push usercmanchester@mozilla.com
push dateSat, 07 Jan 2017 00:20:40 +0000
treeherderautoland@1d126c201b0f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1325801
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1325801 - Fix intermittent failure staging cppunittests. r=mshal Dumping symbols can interfere with staging cppunittests in case calling objcopy from the symbol dumping script coincides exactly with calling objcopy when staging cppunittests when the two are run in parallel. This patch prevents symbol dumping from happening while tests are being packaged. MozReview-Commit-ID: Hgi1zyIZE7K
build/moz-automation.mk
--- a/build/moz-automation.mk
+++ b/build/moz-automation.mk
@@ -73,16 +73,21 @@ automation/pretty-l10n-check: automation
 
 automation/upload: automation/installer
 automation/upload: automation/package
 automation/upload: automation/package-tests
 automation/upload: automation/buildsymbols
 automation/upload: automation/update-packaging
 automation/upload: automation/sdk
 
+# buildsymbols will modify our test binaries, which can interfere with
+# packaging them. A finer-grained dependency can help performance here
+# once bug 1329020 is fixed.
+automation/pretty-package-tests: automation/buildsymbols
+
 # automation/{pretty-}package should depend on build (which is implicit due to
 # the way client.mk invokes automation/build), but buildsymbols changes the
 # binaries/libs, and that's what we package/test.
 automation/pretty-package: automation/buildsymbols
 
 # The installer, sdk and packager all run stage-package, and may conflict
 # with each other.
 automation/installer: automation/package