Bug 1569676 - Make new performance panel's destroy synchronous. r=jdescottes
☠☠ backed out by 8437b860258f ☠ ☠
authorAlexandre Poirot <poirot.alex@gmail.com>
Mon, 05 Aug 2019 10:47:01 +0000
changeset 486211 1bc927ef181a8f0a2cbeb54886b7bf74df7a5d49
parent 486210 5227c89295f4dd87c0a15b150b2eec9d72b54205
child 486212 c0b0e0410a665f532c1abb69bd24142dfcd97b9c
push id91699
push userapoirot@mozilla.com
push dateMon, 05 Aug 2019 16:02:57 +0000
treeherderautoland@997ad11003a3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1569676
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1569676 - Make new performance panel's destroy synchronous. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D39711
devtools/client/performance-new/panel.js
--- a/devtools/client/performance-new/panel.js
+++ b/devtools/client/performance-new/panel.js
@@ -40,17 +40,17 @@ class PerformancePanel {
   }
 
   // DevToolPanel API:
 
   get target() {
     return this.toolbox.target;
   }
 
-  async destroy() {
+  destroy() {
     // Make sure this panel is not already destroyed.
     if (this._destroyed) {
       return;
     }
     this.panelWin.gDestroy();
     this.emit("destroyed");
     this._destroyed = true;
   }