Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra. r=jonco
authorYoshi Cheng-Hao Huang <allstars.chh@gmail.com>
Thu, 09 Jan 2020 15:06:36 +0000
changeset 509579 16dadfc1d2ef54e9a9ebc81a5ebfde6e330b38f9
parent 509578 40f3654a935a8d60a0faa1faa5e29440a054dd8b
child 509580 0bfe04276fe3ef96058cdfe826f638b43090053f
push id104694
push userallstars.chh@gmail.com
push dateThu, 09 Jan 2020 15:21:00 +0000
treeherderautoland@912fed7c5710 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs1603701
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D59302
js/src/tests/jstests.list
js/src/tests/test262-update.py
--- a/js/src/tests/jstests.list
+++ b/js/src/tests/jstests.list
@@ -550,8 +550,41 @@ shell-option(--enable-weak-refs) script 
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-job-not-active-throws.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-prop-desc.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-missing-internal-throws.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-name.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-length.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/Symbol.toStringTag.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/proto.js
 shell-option(--enable-weak-refs) script test262/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-not-object-throws.js
+
+####################################################
+# Enable WeakRef tests in the shell #
+####################################################
+
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/instance-extensible.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/undefined-newtarget-throws.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/target-not-object-throws.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prop-desc.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/browser.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/Symbol.toStringTag.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/browser.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/return-target.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/prop-desc.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/this-not-object-throws.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/this-does-not-have-internal-target-throws.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/custom-this.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/name.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/deref/length.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/prop-desc.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/constructor.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype/proto.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype-from-newtarget-abrupt.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/name.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/proto-from-ctor-realm.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/constructor.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype-from-newtarget.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/proto.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/prototype-from-newtarget-custom.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/returns-new-object-from-constructor.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/length.js
+shell-option(--enable-weak-refs) script test262/built-ins/WeakRef/newtarget-prototype-is-not-object.js
--- a/js/src/tests/test262-update.py
+++ b/js/src/tests/test262-update.py
@@ -33,24 +33,24 @@ UNSUPPORTED_FEATURES = set([
     "regexp-unicode-property-escapes",
     "export-star-as-namespace-from-module",
     "Intl.DateTimeFormat-quarter",
     "Intl.DateTimeFormat-datetimestyle",
     "Intl.DateTimeFormat-dayPeriod",
     "Intl.DateTimeFormat-formatRange",
     "Intl.DisplayNames",
     "Intl.Segmenter",
-    "WeakRef",
     "optional-chaining",
     "top-level-await",
 ])
 FEATURE_CHECK_NEEDED = {
     "Atomics": "!this.hasOwnProperty('Atomics')",
     "FinalizationGroup": "!this.hasOwnProperty('FinalizationGroup')",
     "SharedArrayBuffer": "!this.hasOwnProperty('SharedArrayBuffer')",
+    "WeakRef": "!this.hasOwnProperty('WeakRef')",
 }
 RELEASE_OR_BETA = set([
     "Intl.NumberFormat-unified",
     "Intl.DateTimeFormat-fractionalSecondDigits",
     "Promise.any",
     "AggregateError",
     "String.prototype.replaceAll",
 ])